Re: 4.4.99.902: s3 fails some of xtests

Németh Márton wrote:

> Hi!
>
> I've tested 4.5.0RC2 with xtest 4.0.10, see 
> http://bugs.xfree86.org/show_bug.cgi?id=1557 for details.
>
> I've attached a test C program which always produces bad rendering 
> using acceleration, and never if XaaNoScreenToScreenCopy is set 
> (=without acceleration). The results are also attached.
>
> Have anyone see souch behaviour?
>
> Have anyone programers manual about 86c764/765 [Trio32/64/64V+] chip?


Is it really only GXclear, GXinvert, and GXset that fail?  If so, the 
diagnosis is pretty easy.

For those three ROPs, it's not really a screen-to-screen blit at all: 
the source surface is not used.  Most S3 chips (Savage included) fail if 
you attempt to use a two-operand bitblt command when the source is not 
involved.  That's why there is an XAA flag specifically for this case.

The solution is to add
     pXAA->ScreenToScreenCopyFlags = ROP_NEEDS_SOURCE;
 to the S3AccelInitXxx function at the bottom of the file.

-- 
- Tim Roberts, [email protected]
  Providenza & Boekelheide, Inc.