4.4.99.903: s3: missing some of the screen

Németh Márton <[email protected]>
Newsgroups gmane.comp.xfree86.devel
Message-ID <[email protected]>
Hi!

Starting XFree86 4.4.99.903 using the s3 driver at mode 1024x768 8bpp I 
see the following screen:

       0     303                   1023
       |      |                      |
  0 ---BBBBBBBB----------------------+
       BBBBBBBB                      |
       BBBBBBBB                      |
       BBBBBBBB       GOOD AREA      |
       BBBBBBBB                      |
       BBBBBBBB                      |
  767--BBBBBBBB----------------------+


where B means that black pixels are displayed always.

I don't know what is the problem exactly but the attached patch removes 
this bug. (May cause new ones, too...)

	NMarci


P.S.: My hardware is:

chip:
-----
S3 Trio64V+
    P1E3BF
86C765
9650 MB851
TAIWAN

VGA BIOS:
---------
Phoenix S3 TRIO64V+ Enhanced VGA BIOS. Version 1.02-02
Copyright 1987-1992 Phoenix Technologies Ltd.
Copyright 1992-1995 S3 Incorporated.
All Rights Reserved

lspci -v:
---------
0000:00:09.0 VGA compatible controller: S3 Inc. 86c764/765 
[Trio32/64/64V+] (rev 54) (prog-if 00 [VGA])
         Flags: medium devsel, IRQ 10
         Memory at e0000000 (32-bit, non-prefetchable) [size=64M]
s3-black-bug.patch (text/plain, 484 B)
--- xc/programs/Xserver/hw/xfree86/drivers/s3.orig/s3_driver.c	2005-03-11 09:41:49.000000000 +0100
+++ xc/programs/Xserver/hw/xfree86/drivers/s3/s3_driver.c	2005-03-11 10:51:44.000000000 +0100
@@ -1120,9 +1120,6 @@
 	if (!vgaHWInit(pScrn, mode))
 		return FALSE;
 
-	/* We have horizontal blank end extension bits, so undo KGA workaround */
-	vgaHWHBlankKGA(mode, pVga, 0, 0);
-
 	pVga->MiscOutReg |= 0x0c;
 	pVga->Sequencer[0] = 0x03;
 	pVga->CRTC[19] = pS3->s3BppDisplayWidth >> 3;
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.