Re: Small fix for XKB.

David Dawes <[email protected]>
Newsgroups gmane.comp.xfree86.devel
Message-ID <[email protected]>
On Mon, Apr 11, 2005 at 05:56:01PM +0700, Ivan Pascal wrote:
>  Hello,
>
>I apologise for my slowness but I'd like to add small patch to Xserver XKB code.
>The thing is that the bug was already fixed long ago but then came back.
>The problem was reported in Bugzilla #1566.  After some questions I found the
>symptoms are wellknown for me and I had fixed the bug before 4.1.0.
>Therefore I thought the reporter somehow got XFree based on some old release
>or some Xorg's server where the patch was applied later.
>
>But when I got similar complains in e-mail I decided to check sources and
>found out that my patch was reverted completely becouse of compilation warnings
>(signed-unsigned assignment without explicit cast).  Of course it's my fault
>that the fix causes warnings but the reverting caused the bug came back.
>
>New patch (attached) is more correct and should not harm something.

Looks OK to me.  Is it needed for the second XkbAdjustGroup() call too?

David
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.