Re: Darwin extern/static fix
David Dawes <[email protected]>
| Newsgroups | gmane.comp.xfree86.devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Apr 13, 2005 at 11:52:47AM -0700, Torrey Lyons wrote: >Bugzilla #1576 and the fix committed for it is only partially right. >The patch applewmExt.h is right, but patching the imported Mesa code >in extras/Mesa/include/GL/internal/dri_interface.h is the wrong thing >to do and likely has unintended side effects on other platforms. The >correct fix is just to rename __driConfigOptions in >lib/GL/apple/dri_glx.c. Thanks for pointing out the issue. I didn't find anything that requires the external declaration of __driConfigOptions, which is why I applied the patch as submitted. Perhaps something should in the BUILT_IN_DRI_DRIVER case. There are also likely other issues with the BUILT_IN_DRI_DRIVER case. David