Re: Re: CVS Update: xc (branch: trunk)

Quoting Branden Robinson <[email protected]>:

  Hi,

> >    437. Fix the number of beeps when using AccessX and XKB
> >         (#A.1302, Alan Coopersmith).
> 
> I applied this patch to Debian's 4.2.1-4 packages and I have a report
> that this causes nonstop beeping until the server exits if one uses
> PointerKeys_Enable (i.e., Shift-NumLock).
> 
> I just reproduced this, and am going to have to restart my X server.
> 
> :(
> 
> Is the above patch perhaps dependent on some other changes to XKB
> post-4.2?

  Please try this patch:
--
Index: xc/programs/Xserver/xkb/ddxBeep.c
===================================================================
RCS file: /opt/XFree86/xc/programs/Xserver/xkb/ddxBeep.c,v
retrieving revision 3.8
retrieving revision 3.9
diff -u -r3.8 -r3.9
--- xc/programs/Xserver/xkb/ddxBeep.c	30 Oct 2002 12:52:44 -0000	3.8
+++ xc/programs/Xserver/xkb/ddxBeep.c	5 Dec 2002 21:59:00 -0000	3.9
@@ -322,7 +322,7 @@
 		next = SHORT_DELAY;	    
 	    break;
     }
-    if (duration>0) {
+    if (timer == NULL && duration>0) {
 	CARD32		starttime = GetTimeInMillis();
 	CARD32		elapsedtime;
 
--

  This may not be the best fix, but corrects the problem if a timer being
set just when the previous one finished.

> -- 
> G. Branden Robinson                |      The noble soul has reverence
> for
> Debian GNU/Linux                   |      itself.
> [email protected]                 |      -- Friedrich Nietzsche
> http://people.debian.org/~branden/ |

Paulo