Re: [PATCH 2/2] Fixed couple of compilator warning and removed unused macros.

"Carlos R. Mafra" <[email protected]>
Newsgroups gmane.compw.window-managers.windowmaker.devel
Message-ID <[email protected]>
On Sat, 25 Feb 2017 at  8:00:23 +0100, Roman Dobosz wrote:
> ---
>  WINGs/wcolorpanel.c |  3 ---
>  WINGs/wfontpanel.c  |  4 ++--
>  WINGs/wsplitview.c  |  3 ---
>  src/defaults.c      |  9 ++++-----
>  src/wmspec.c        |  1 -
>  src/workspace.c     |  1 -
>  util/wmiv.c         | 11 ++++++-----
>  7 files changed, 12 insertions(+), 20 deletions(-)

Ideally the commit message should contain the warnings
that you're addressing in order to give structure to
the patch and make reviewing easier.

Could you do this next time?

In any case, thank you for your work!


-- 
To unsubscribe, send mail to [email protected].
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.