Re: [PATCH 2/2] Fixed couple of compilator warning and removed unused macros.
Andreas Tscharner <[email protected]>
| Newsgroups | gmane.compw.window-managers.windowmaker.devel |
|---|---|
| Organization | Verein der Informatikstudierenden an der ETH Zü rich |
| Message-ID | <[email protected]> |
On 25.02.2017 08:00, Roman Dobosz wrote:
[snip]
> diff --git a/util/wmiv.c b/util/wmiv.c
> index e99e3e3..64e6eb5 100755
> --- a/util/wmiv.c
> +++ b/util/wmiv.c
> @@ -35,6 +35,7 @@
> #include <unistd.h>
> #include <sys/stat.h>
> #include <getopt.h>
> +#include <math.h>
> #include "config.h"
>
> #ifdef HAVE_EXIF
> @@ -218,7 +219,7 @@ int rescale_image(void)
> long final_height = img->height;
>
> /* check if there is already a zoom factor applied */
> - if (zoom_factor != 0) {
> + if (fabsf(zoom_factor) <= 0.0f) {
Are you sure about that one? I don't know the other code and what or
what not can happen to "zoom_factor" but (zoom_factor != 0) and
(fabs(zoom_factor <= 0.0f) are certainly not the same.
Best regards
Andreas
--
("`-''-/").___..--''"`-._
`o_ o ) `-. ( ).`-.__.`)
(_Y_.)' ._ ) `._ `. ``-..-'
_..`--'_..-_/ /--'_.' .'
(il).-'' (li).' ((!.-'
Andreas Tscharner [email protected] ICQ-No. 14356454
--
To unsubscribe, send mail to [email protected].