Re: [PATCH 1/2] wmaker: Remove global WindowMaker file from source.

On 03/18/2017 04:09 PM, Doug Torrance wrote:
> The default values for all of the various Window Maker configuration options
> are given in src/defaults.c.  Many are also given in
> WindowMaker/Defaults/WindowMaker.
>
> In many cases, these default options do not agree.  For example,
> src/defaults.c gives the default value of OpaqueMove as NO, but
> W/D/WindowMaker has it as YES.  There also some options in W/D/WindowMaker
> which no longer exist, e.g., PopupSwitchMenu.
>
> It is apparent that it is difficult to maintain these defaults in both
> locations.  Also, a global W/D/WindowMaker file is only necessary for system
> administrators or distribution package maintainers who would like to change
> the default values for all of their users.  Everyone else will just use
> WPrefs or edit ~/GNUstep/Defaults/WindowMaker.
>
> The only advantage I see to having W/D/WindowMaker in the source tree is to
> serve as an example.  But there are other sources of documentation, e.g.:
> http://windowmaker.org/chap4.php
>
> I propose that we remove this file entirely and keep the default config
> values in one location: src/defaults.c.

D'oh, I really should have tested this patch a bit more *before* I sent 
it in.

If there's no global WindowMaker file, an error window appears.  An easy 
fix to have a very minimal file, e.g., containing only "{}".

I'll send a new version in a moment.

Doug


-- 
To unsubscribe, send mail to [email protected].