Re: [PATCH 23/23] Code refactoring: replaced macro 'XDND' by 'USE_DOCK_XDND' for consistency

----- Rodolfo García Peñas <[email protected]> a écrit :
> On Thu, 25 Jun 2015, Rodolfo kix Garcia escribió:
> > 
> > [...]
> > kix@debian:~/src/wmaker/wmaker-crm$ grep xdnd.c src/*
> > src/Makefile:am__append_1 = xdnd.c
> > src/Makefile:   wmspec.c workspace.c workspace.h wsmap.c wsmap.h xdnd.c \
> > src/Makefile.am:wmaker_SOURCES += xdnd.c
> > src/Makefile.in:@USE_DOCK_XDND_TRUE@am__append_1 = xdnd.c
> > src/Makefile.in:        wmspec.c workspace.c workspace.h wsmap.c wsmap.h xdnd.c \
> > kix@debian:~/src/wmaker/wmaker-crm$
> > 
> > I am in this commit:
> > 
> > kix@debian:~/src/wmaker/wmaker-crm$ git log --oneline | head -1
> > c3ba9ae wmaker: moved calculation of internal offset in handleDockMove outside the loop
> > kix@debian:~/src/wmaker/wmaker-crm$
> > 
> > Thanks a lot,
> > Cheers,
> > kix
> 
> Hi, the code has problems:
> 
> kix@debian:~/src/wmaker/wmaker-crm$ grep enable_dock_xdnd configure.ac
> AM_CONDITIONAL([USE_DOCK_XDND], [test "x$enable_dock_xdnd" != "xno"])
> kix@debian:~/src/wmaker/wmaker-crm$
> 
> The variable "enable_dock_xdnd" is never set, so the value is always empty (""). Therefore the test is always true.
> 
> Cheers,
> kix

Hi,

I confirm, the name of the variable is not the right one, a leftover from an old patch... I have made a patch to fix this, I have put your name on it because you've done the biggest part of the work so you deserve it more than me.

Thanks again for taking time to deep check it all!

Regards,
Christophe.


-- 
To unsubscribe, send mail to [email protected].