Re: Bug: Slow to switch between workspaces.

On Thu, 12 Feb 2015 at 16:00:06 -0300, Juan Giordana wrote:
> Hello,
> 
> On *next, configured without arguments, when I switch between
> workspaces the operation is slow, i.e., moving back and forward the
> mouse wheel.
> 
> This issue doesn't happen on *master.

The patch below should fix this, please test it.

From fc437783f990c03519821ccfb655cd637db003dc Mon Sep 17 00:00:00 2001
From: "Carlos R. Mafra" <[email protected]>
Date: Sat, 25 Jul 2015 14:23:46 -0300
Subject: [PATCH] Disable pager by default

New features like this one should be disabled by default.

Signed-off-by: Carlos R. Mafra <[email protected]>
---
 WPrefs.app/Expert.c | 4 ++--
 src/WindowMaker.h   | 2 +-
 src/defaults.c      | 4 ++--
 src/event.c         | 2 +-
 src/workspace.c     | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/WPrefs.app/Expert.c b/WPrefs.app/Expert.c
index 616f9ec..0c5df94 100644
--- a/WPrefs.app/Expert.c
+++ b/WPrefs.app/Expert.c
@@ -47,8 +47,8 @@ static const struct {
 	{ N_("Ignore decoration hints for GTK applications."),
 	  /* default: */ False, OPTION_WMAKER, "IgnoreGtkHints" },
 
-	{ N_("Disable workspace pager."),
-	  /* default: */ False, OPTION_WMAKER, "DisableWorkspacePager" },
+	{ N_("Enable workspace pager."),
+	  /* default: */ False, OPTION_WMAKER, "EnableWorkspacePager" },
 
 	{ N_("Do not set non-WindowMaker specific parameters (do not use xset)."),
 	  /* default: */ False, OPTION_USERDEF, "NoXSetStuff" },
diff --git a/src/WindowMaker.h b/src/WindowMaker.h
index 99751ff..21da64d 100644
--- a/src/WindowMaker.h
+++ b/src/WindowMaker.h
@@ -395,7 +395,7 @@ extern struct WPreferences {
 	char sticky_icons;                 /* If miniwindows will be onmipresent */
 	char dont_confirm_kill;            /* do not confirm Kill application */
 	char disable_miniwindows;
-	char disable_workspace_pager;
+	char enable_workspace_pager;
 	char ignore_gtk_decoration_hints;
 
 	char dont_blink;                   /* do not blink icon selection */
diff --git a/src/defaults.c b/src/defaults.c
index 6f9edfd..caa428e 100644
--- a/src/defaults.c
+++ b/src/defaults.c
@@ -363,8 +363,8 @@ WDefaultEntry staticOptionList[] = {
 	    NULL, getBool, setClipMergedInDock, NULL, NULL},
 	{"DisableMiniwindows", "NO", NULL,
 	    &wPreferences.disable_miniwindows, getBool, NULL, NULL, NULL},
-	{"DisableWorkspacePager", "NO", NULL,
-	    &wPreferences.disable_workspace_pager, getBool, NULL, NULL, NULL}
+	{"EnableWorkspacePager", "NO", NULL,
+	    &wPreferences.enable_workspace_pager, getBool, NULL, NULL, NULL}
 };
 
 #define NUM2STRING_(x) #x
diff --git a/src/event.c b/src/event.c
index a6a5402..e7ee074 100644
--- a/src/event.c
+++ b/src/event.c
@@ -1622,7 +1622,7 @@ static void handleKeyPress(XEvent * event)
 		break;
 
 	case WKBD_WORKSPACEMAP:
-		if (!wPreferences.disable_workspace_pager)
+		if (wPreferences.enable_workspace_pager)
 			StartWorkspaceMap(scr);
 		break;
 
diff --git a/src/workspace.c b/src/workspace.c
index c6052b3..e3efcfd 100644
--- a/src/workspace.c
+++ b/src/workspace.c
@@ -475,7 +475,7 @@ void wWorkspaceForceChange(WScreen * scr, int workspace)
 	if (workspace >= MAX_WORKSPACES || workspace < 0)
 		return;
 
-	if (!wPreferences.disable_workspace_pager && !w_global.process_workspacemap_event)
+	if (wPreferences.enable_workspace_pager && !w_global.process_workspacemap_event)
 		wWorkspaceMapUpdate(scr);
 
 	SendHelperMessage(scr, 'C', workspace + 1, NULL);
-- 
2.1.4


-- 
To unsubscribe, send mail to [email protected].