Re: [PATCH] configure: combine Git SHA with WMaker version

Paolo Pisati <[email protected]>
Newsgroups gmane.compw.window-managers.windowmaker.devel
Message-ID <[email protected]>
On Sun, Jul 26, 2015 at 11:22:18PM +0100, Carlos R. Mafra wrote:
> On Mon, 27 Jul 2015 at  0:02:07 +0200, Paolo Pisati wrote:
> > On Sun, Jul 26, 2015 at 10:48:08PM +0100, Carlos R. Mafra wrote:
> > > 
> > > What happens if you don't have git installed?
> > 
> > 
> > I thought we were just distributing the source via git (thus one is supposed to
> > have git installed), but i see your point - i should wrap the SHA part in a
> > shell script that fails graciously in case git is missing.
> 
> Furthermore, I think that simply appending the sha1 unconditionally is
> annoying. For a released version we want to have eg '0.95.6' and
> not '0.95.6-3bd9e83'. The sha1 string should be present only in between
> full releases.

Right, but i don't think there's a way to distinguish between the two - you
should just comment it out when you cut a new release and re-enable it
afterwards.

But i'm an autotool expert, so i'm eager to hear suggestions.
-- 
bye,
p.


-- 
To unsubscribe, send mail to [email protected].
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.