Re: [PATCH 01/14] wmkeys compilation bugs

On Sat, 15 Aug 2015 at 23:15:11 +0000, Rodolfo García Peñas (kix) wrote:
> 
> Doug Torrance <[email protected]> escribió:
> 
> >On 08/15/2015 06:29 PM, Rodolfo García Peñas (kix) wrote:
> >>I modified all other dockapps.
> >
> >Thanks for doing this!
> >
> >>The wmbiff dockapp includes a different wmgeneral library. This dockapp
> >>doesn't compile. I don't include this new code in libdockapps because
> >>include code of application that doesn't compile IMO is not a good idea.
> >>
> >>Probably we should try to compile the wmbiff dockapps, and then, think
> >>about include or not the three new functions in libdockapp.
> >
> >This is something I've looked at a little bit.  I have a branch [1] with
> >a partially working wmbiff which uses the shared wmgeneral library
> >(after adding the wmbiff-specific functions to the library, as you
> >mentioned).
> >
> >However, wmbiff is special in that it allows non-64x64 windows, and this
> >is the main diverence from the main wmgeneral functions.  I haven't
> >gotten around to solving this issue yet.
> >
> >Doug
> >
> >[1] https://github.com/d-torrance/dockapps/tree/update-wmbiff
> 
> Hi Doug,
> 
> we can compile it with this little change in tlsComm.c:
> 
> -struct connection_state *initialize_gnutls(UNUSED(int sd),
> +struct connection_state *initialize_gnutls(UNUSED(intptr_t sd),

Could you write this one-liner as a standalone patch to the current
repo? I've just checked here that it indeed fixes the compilation,
and it is good to have this change separated from any others.


-- 
To unsubscribe, send mail to [email protected].