Re: Question about menus (usermenu, appmenu)
"Rodolfo García Peñas (kix)" <[email protected]>
| Newsgroups | gmane.compw.window-managers.windowmaker.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Josip, thanks for your report. Sorry about that. Patch is attached. Perhaps we should use a different flag to run the application more times from the same dock icon. Cheers, kix Josip Deanovic <[email protected]> escribió: > On Saturday 2015-08-22 16:53:56 Carlos R. Mafra wrote: >> On Sat, 22 Aug 2015 at 15:11:33 +0200, Josip Deanovic wrote: >> > Let's not remove anything until we find out what this really is. >> > There are some features still missing because of such actions in >> > the past. >> >> Which feature was removed that you are missing? > > The one I am talking for over a year now. :-) > > In previous versions e.g. 0.80.2 up until 0.95.3 when an application > attributes are set with "NoAppIcon = Yes;" ("No application icon" option > in attributes window), it was possible to launch multiple instances of > the application from wmdock using double-click. > > > After doing a git bisect per your suggestion I have found and reported > this: > > bc0700e016c67791d3e3eab855543d849f4ce786 is the first bad commit > commit bc0700e016c67791d3e3eab855543d849f4ce786 > Author: Rodolfo GarcÃa Peñas (kix) <[email protected]> > Date: Mon Jun 18 11:15:19 2012 +0200 > > Create WAppIcon always > > When the application is created, the WAppIcon now is created always, > but it is only painted if the flag is not set. > > The icon initialization to NULL can be done now at > app_icon_create_from_docks > because it is always called. > > :040000 040000 7c58877ad5af211acaddac5288848c2ade7b04cb > 33d52affb385d22fbf04ebad3c628b714008785d M src > > > > For the complete thread look for a subject "Double-click on application in > wmdock does not launch the application if one instance is already > running". > > > -- > Josip Deanovic > > > -- > To unsubscribe, send mail to [email protected]. Rodolfo García Peñas (kix) http://www.kix.es/
0001-create_appicon_from_dock-checks-if-no_appicon-flag-i.patch
(text/x-diff, 2.1 KB)
From ccff70a14d18fb68b2869f1fe05d6069c9552b26 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rodolfo=20Garc=C3=ADa=20Pe=C3=B1as=20=28kix=29?= <[email protected]> Date: Sun, 23 Aug 2015 17:33:38 +0200 Subject: [PATCH] create_appicon_from_dock checks if no_appicon flag is set MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As Josip Deanovic reported: -------8<------- In previous versions e.g. 0.80.2 up until 0.95.3 when an application attributes are set with "NoAppIcon = Yes;" ("No application icon" option in attributes window), it was possible to launch multiple instances of the application from wmdock using double-click. After doing a git bisect per your suggestion I have found and reported this: bc0700e016c67791d3e3eab855543d849f4ce786 is the first bad commit commit bc0700e016c67791d3e3eab855543d849f4ce786 Author: Rodolfo GarcÃa Peñas (kix) <[email protected]> Date: Mon Jun 18 11:15:19 2012 +0200 Create WAppIcon always When the application is created, the WAppIcon now is created always, but it is only painted if the flag is not set. The icon initialization to NULL can be done now at app_icon_create_from_docks because it is always called. :040000 040000 7c58877ad5af211acaddac5288848c2ade7b04cb 33d52affb385d22fbf04ebad3c628b714008785d M src -------8<------- This patch reverts this change (not the patch). Now the function create_appicon_from_dock checks if the flag no_appicon is set, and then, do not execute the code related to the appicon. Signed-off-by: Rodolfo García Peñas (kix) <[email protected]> --- src/appicon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/appicon.c b/src/appicon.c index 302066d..08331c7 100644 --- a/src/appicon.c +++ b/src/appicon.c @@ -1180,7 +1180,7 @@ static void create_appicon_from_dock(WWindow *wwin, WApplication *wapp, Window m } /* If created, then set some flags */ - if (wapp->app_icon) { + if (wapp->app_icon && !WFLAGP(wapp->main_window_desc, no_appicon)) { WWindow *mainw = wapp->main_window_desc; wapp->app_icon->running = 1; -- 2.5.0