Re: getstyle cannot create target file

Hi Carlos,

>
>> 2. If it's a legit bug, would you like a patch?
>
> Of course, please!
>
>> I'm not too familiar with the WindowMaker codebase so it might take a
>> while, but fixing something in util/ looks like a good way to get the
>> hang of it (and the fix doesn't seem to require anything too
>> wmaker-specific).
>
> You have a case about which you personally care, that's the
> recipe for motivation. And fixing it will not only help yourself
> but also others in the future.

Oh, definitely :-) I just wanted to make sure I'm not fixing a 
deprecated tool or duplicating the effort of someone who's already 
working on it.

I'll have a more in-depth look at what exactly getstyle is doing and try 
to come up with a correct fix. I didn't dig too deply, but it looks like 
it's looping through what I assume is a list of current settings, (i.e. 
paths to the current background image, the various pixmaps used for 
textures) and packing those into known places.

Simplifying the themed paths (e.g. by copying all pixmaps, textures and 
images in a <theme>/image directory) would naturally take care of the 
paths problem, but it looks like a pretty big change and I would rather 
not try to do that on a codebase I don't know inside-out. I.e. I want to 
make sure that whatever I write fits into the whole machine, such that 
your observation:

> I think your observations make sense. If you can turn them to
> a patch the result will most likely be an improvement.

actually holds in fact, not just in theory :-).

Thanks for your answer!

Alex


-- 
To unsubscribe, send mail to [email protected].