Re: getstyle cannot create target file

On Mon, 18 Apr 2016 at 22:30:18 +0300, Alexandru Lazar wrote:
> I'm piggybacking on my own message: is there any (historical, I
> presume) reason why, when packing a theme, getstyle relocates files
> with their whole path? I.e. from /long/path/to/file.png to
> themeDir/long/path/to/file.png?

There were recent patches touching these path creation routines
that could very well have introduced odd behavior.

Just do a:

git log util/getstyle.c

to see that there were patches touching these precise areas.

> It seems to me that a much cleaner solution is to relocate
> /long/path/to/file.png to themeDir/assets/file.png. The only problem
> this seems to have is that a theme creator may use files with the
> same name, but located in different places, and getstyle would
> either have to rename these automatically (not too difficult) or
> bork and warn the user (trivial, but possibly annoying to use).

If you're copying the files to themeDir/assets then why is this
a problem for getstyle? Why would it care about other files elsewhere?
Note that I haven't read the code, so this is just a "common sense"
type of question.


-- 
To unsubscribe, send mail to [email protected].