Re: [PATCH 0/2] Fix for fullscreen window being obscured by panel

On Tue, 12 Jul 2016 at 23:49:45 +0200, Bjørn Mork wrote:
> Hello,
> 
> Since this is my first time here I'd like to introduce myself: I have
> been a dedicated Window Maker user for a very long time.  I guess it's
> close to 20 years now. Like many others I was looking for a more
> beautiful window manager back in the 1990s, but got frustrating
> whenever they crashed. The window manager was as close to a session
> manager as we got, and a crash would mean a lost session. Then Window
> Maker showed up.  Both beautiful and stable.  I've never looked back.
> 
> But last week I got a new laptop and fealt the need for something
> new. In particular a "panel" application which could collect all the
> useful freedesktop applets. Yes, I know about wmsystemtray. That
> didn't work so good for me since the applet icons end up really tiny
> on a 2560x1440 14" screen.  So I ended up with the LXDE lxpanel. It
> does make the desktop look like it was designed by Frankenstein, but
> you cannot always get everything ;)
> 
> Now finally, to the real issue: The panel obscured fullscreen windows.
> This is particularily annoying while watching movies. After a failing
> to find a setting for that, I started looking at the lxpanel source.
> And found that it looked mostly sane.  No issues there.  So I went on
> to the Window Maker source, and quickly found the change that made
> this happen. The fullscreen stacking level was removed in an attempt
> to solve the issue of fullscreen windows being stacked above focused
> windows: http://lists.windowmaker.org/dev//msg05863.html
> 
> This made fullscreen windows stack like normal windows, which implies
> *below* the dock/panel.... I see that this bug has come up before:
> http://lists.windowmaker.org/dev/msg07312.html
> 
> This is a revert of the patches introducing the problem, and a feeble
> attempt on solving the unfocused fullscreen issue.  I'm a bit unsure
> about the latter.


Right, I don't think we should have removed the fullscreen level
back then and now you spotted that this is against the specs.

I applied both patches, but the second one where you create an
exception to allow other windows on top of a fullscreen window
seems like trying to solve the wrong problem --- if you have
a fullscreen window you better not mess with other windows, and
if you really want to do that you should first make sure to
not have a fullscreen window blocking the screen.

I applied your patch anyway. It would be nice to hear from Amadeusz
what he thinks about this behavior.


-- 
To unsubscribe, send mail to [email protected].