Re: Adding Freefall
Nuno Silva <[email protected]> Wed, 26 Mar 2025 19:00:53 +0000
| Newsgroups | gmane.discuss |
|---|---|
| Message-ID | <[email protected]> |
On 2025-03-26, Nuno Silva wrote: > On 2025-03-26, Adam Sjøgren wrote: > >> Nuno writes: >> >>> if I'm not misreading the code, in gnus-html.el, href's value is >>> assumed to be surrounded by double quotes. >> >> That sounds odd, in HTML '' and "" can be used interchangably. >> >> Oh, you're talking about washing, not about rendering HTML with shr? > > Not sure how it's called, but yes, I think so. > > I guess I moved away from shr a long time ago to avoid the dependency on > libxml2. > >> I would guess the washing functions are more ad-hoc than shr. > > I'm surprised that it has remained this way so far, nobody else has been > hitting this issue? > > What'd be the proper thing to do here? I suppose redefining the function > to try two different regexes? > > (Also, could/should I crosspost this to some Gnus group?) The quick and dirty hack of changing it to (when (or (string-match "href=\"\\([^\"]+\\)" parameters) (string-match "href='\\([^\']+\\)" parameters)) appears to work. Now how ugly is this and what have I broken? -- Nuno Silva