Re: vincent - r31419 - abiword/branches/gsoc2012dialogs/src/wp/ap/xp
Vincent Kang <[email protected]>
| Newsgroups | gmane.editors.abiword.devel |
|---|---|
| Message-ID | <CAKhPGznooBaSnZ+Y9moJgLSC3+nyi5sJha0D-eEvtNtxQGo2Hw@mail.gmail.com> |
Hi Hub, thanks for your advices, 1. using UT_UTF8String, is because the preview variables defined in FrameFormat.cpp are UT_UTF8String. I will pay more attention of that. 2. I will fix 'UT_std_sprinf' issue soon thanks, Vincent 2012/6/27 Hubert Figuière <[email protected]>: > > On 25/06/12 08:40 AM, [email protected] wrote: >> >> Author: vincent >> Date: 2012-06-25 17:40:21 +0200 (Mon, 25 Jun 2012) >> New Revision: 31419 >> >> Modified: >> abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.cpp >> abiword/branches/gsoc2012dialogs/src/wp/ap/xp/ap_Dialog_FormatFrame.h >> Log: >> code refactor: >> 1. add UT_UTF8String m_sWidth & m_sHeight; > > > The use of UT_UTF8String in new code is deprecated. Please use > std::string instead. > Also use the corresponding UT_std_sprinf() instead of a sprintf() to a > stack buffer. > > > Thanks, > > Hub