Re: aaditya - r31457 - in abiword/branches/gsoc2012_rotated_text/src: af/gr/xp text/fmt/xp

On 06/07/12 11:10 PM, Aaditya Chauhan wrote:
> 
> Hi Hub,
> 
> Thanks for pointing this out. I will recommit the code with the
> changes you have pointed out.
> 
> A doubt :-
> 
> there are functions like these, present in gr_Graphics.cpp, is there
> any particular reason for not inlining them ?
> 
> void GR_Graphics::flush(void)
> {
> 	// default implementation does nothing
> }

The mistake is that void GR_Graphics::flush() that is declared as
virtual should be pure virtual at that level. This is probably from a
decade ago and hasn't been fixed.

If a function is virtual, there is no point inlining it as it won't be.


Hub