[PATCH] Disable pointless menu entry
Ingo Brückl <[email protected]>
| Newsgroups | gmane.editors.abiword.devel |
|---|---|
| Message-ID | <[email protected]> |
What about disabling the menu entry for "purge history"? It actually doesn't purge the *history*, but the *revisions* and is a duplicate of the menu entry "purge revisions" which does exactly the same (and has the right label). There doesn't seem to be a function that purges all history, and it is confusing for the user to have a menu entry that doesn't do what it says but something completely different. Ingo
purgeAllHistory.patch
(text/x-diff, 1.3 KB)
Index: src/wp/ap/xp/ap_Menu_ActionSet.cpp =================================================================== --- src/wp/ap/xp/ap_Menu_ActionSet.cpp (revision 31688) +++ src/wp/ap/xp/ap_Menu_ActionSet.cpp (working copy) @@ -388,7 +388,7 @@ _s(AP_MENU_ID_TOOLS_HISTORY, 1,0,0,0, NULL, NULL, NULL); _s(AP_MENU_ID_TOOLS_HISTORY_SHOW, 0,1,0,0, "history", ap_GetState_History, NULL); _s(AP_MENU_ID_TOOLS_HISTORY_PURGE, 0,0,0,0, "purgeAllRevisions", ap_GetState_HasRevisions, NULL); - + // should be: purgeAllHistory !!! _s(AP_MENU_ID_WINDOW, 1,0,0,0, NULL, NULL, NULL); _s(AP_MENU_ID_WINDOW_NEW, 0,0,0,0, "newWindow", NULL, NULL); _s(AP_MENU_ID_WINDOW_1, 0,0,0,0, "activateWindow_1", ap_GetState_Window, ap_GetLabel_Window); Index: src/wp/ap/xp/ap_Menu_Layouts_MainMenu.h =================================================================== --- src/wp/ap/xp/ap_Menu_Layouts_MainMenu.h (revision 31688) +++ src/wp/ap/xp/ap_Menu_Layouts_MainMenu.h (working copy) @@ -288,7 +288,7 @@ MenuItem(AP_MENU_ID_TOOLS_REVISIONS_COMPARE_DOCUMENTS) MenuItem(AP_MENU_ID_TOOLS_REVISIONS_AUTO) #if !XAP_SIMPLE_MENU - MenuItem(AP_MENU_ID_TOOLS_HISTORY_PURGE) + //MenuItem(AP_MENU_ID_TOOLS_HISTORY_PURGE) #endif EndSubMenu()