Re: ib - r31623 - abiword/trunk/src/af/gr/xp

Hi Ingo,

On Tue, Aug 7, 2012 at 7:05 AM, Ingo Brückl <[email protected]> wrote:
> Simon Larochelle wrote on Sun, 5 Aug 2012 15:57:39 -0400:
>
>> I made a patch to solve the first issue (stop using Symbol and
>> Dingbats fonts). It is attached to bug #12334.
>
> The good news: It seems to work now.
>
> After your patches I've applied symbols.l.remove.patch for a clean
> environment and have removed my fontconfig Dingbats font mapping.
>
> There are some remaining issue though.
>
> (1) The first one is a new display issue. The display area for the bullets
> glyphs seems too small, i.e. bullets like hands, arrows and arrowheads are
> cut at the right side, missing the finger, tip and head. This is with font
> selection of current font and wasn't the case before the your patches. It's
> a (annoying) display issue, the print seems ok.

The function GR_CairoGraphics::measureString needs to be modified to
allow for font substitution. I have a working patch for that.

>
> (2) We are still forcing (changing) field font "Symbol" for two bullets in
> RTF import/export (and MsWord_97 import, and "Dingbats" in RTF export). I'm
> not sure, but is RTF import used for AbiWord's internal copy and paste, too?
> (I can't test, because pasting still crashes on my system - a bug still to be
> examined.)
>
I will look into it. I need to figure out which part is required by
the RTF specification and which part was for our internal copy/paste.

> (3) The issues with the "Insert Symbol" dialog and TTF Symbol remain. We
> could remove the whole Symbol/Dingbats stuff (no longer needed after your
> patch, see remove.symbol.dingbats.patch) from gr_CairoGraphics.cpp which
> fixes these issues then.
>
The dialog "Insert Symbol" should probably be renamed "Insert
Character" and open with the current font.
And getting rid of the symbol/dingbat shift functions seems like a good idea.

> (4) BTW, there are still usages of Symbol in fl_BlockLayout.cpp and
> xap_Draw_Symbol.cpp.
>
> So, were do we stand now? I'd vote for your patches and would myself commit
> the two attached patches afterwards. Issue still to be solved / things still
> to look at are: (1), (2), and (4). All in all, things are greatly improved
> now.
>
> Ingo

We also need to test the patch on Windows since we are not using
Pango-Cairo there.
I will wait after the release of version 2.9.4 to commit my patches.

Simon