Re: Crash when pasting Unicode text from Firefox [patch]

OK, we have no more crash after Ingo's commit, but pasting does not
work. Should we apply Ying-Chun Liu's patch? I'm not an expert about the
various unicode representations, so that I am not sure about that. For
those who miss part of this discussion, the patch is:

Index: src/af/xap/xp/xap_EncodingManager.cpp
===================================================================
--- src/af/xap/xp/xap_EncodingManager.cpp	(révision 31751)
+++ src/af/xap/xp/xap_EncodingManager.cpp	(copie de travail)
@@ -1260,10 +1260,10 @@
 		"UTF-16-BE",		// my guess
 		0 };
 	static const char * (szUCS2LENames[]) = {
+		"UTF-16LE",			// superset
 		"UCS-2LE",			// preferred
 		"UCS-2-LE",			// older libiconv
 		"UNICODELITTLE",	// older glibc
-		"UTF-16LE",			// superset
 		"UTF-16-LE",		// my guess
 		0 };


Jean

Le mardi 14 août 2012 à 01:16 +1000, Dmitry Smirnov a écrit :
> On Tue, 14 Aug 2012 00:59:44 Chris Leonard wrote:
> > I'm not a coder so I cannot comment on your patch, but as someone who
> > cares deeply about L10n, Unicode is obviously very important to me and
> > I want to thank you for working on this issue, which will benefit many
> > of our users.
> 
> Thank you for your kind words. :)
> 
> However I can't take the credits for the patch as I'm illiterate in CPP.
> I merely tested and forwarded it but all the work is done by Ying-Chun Liu 
> (PaulLiu) who deserve all the gratitude. 
> 
> Cheers,
> Dmitry.