Re: about two bugs related with Tables

Hi Joe,

Bug 8707 is fixed now. I've marked it as such in bugzilla.

Bug 8984 is still present. I believe it occurs because the special
case code used to handle bugs at the beginning of a document doesn't
work for headers or footers.

headers and footers are special sections placed at the end of the
document. The piecetable structure looks like:

<section type="header"><table><cell><p></cell></table>

Normally the caret can only be placed within a  paragraph. This makes
it impossible to select a table at the beginning of  asection. I wrote
special case code to table this situation.

The special case code handles situations like this:

<section><table><cell><p></cell></table>

I suggest you investigate this special case code and see if it can be
modified to handle tables at the beginning of headers and footers.

I believe this special case code lives in

src/text/fmt/xp/fv_View_protected.cpp

in the method

FV_View::::_charMotion(  ,  )
Look in here to try to fix the bug.

In particular you need to set the boolean member parameter:

m_bInsertAtTablePending = true;

So that abiword knows we're in this special condition.

This will be a rather challenging job I think. Also please don't
assume that my diagnosis of the problem is correct. If this was an
easy bug to fix it would have been fixed by now :-)

Cheers

Martin



On 11 April 2013 02:53, joe joe <[email protected]> wrote:
>
> Hi guys,
>
> I am trying to address two bugs related with Tables. These two bugs
> are related with My interested GSOC project: table improvement.
> some codes have been finished on branches: tableimprove
>
> http://bugzilla.abisource.com/show_bug.cgi?id=8707   Table can't be
> completely selected
> http://bugzilla.abisource.com/show_bug.cgi?id=8984   Table selection
> not drawn in header
>
>
> Anyone have some tips about Table improvement, go ahead to share with me, thanks
>
>
> Joe