Re: joehe - r33361 - abiword/branches/gsoc2013tables/src/text/fmt/xp

Hubert Figuière <[email protected]> Wed, 07 Aug 2013 11:58:51 -0400
Newsgroups gmane.editors.abiword.devel
Message-ID <[email protected]>
On 07/08/13 10:40 AM, [email protected] wrote:
> Modified: abiword/branches/gsoc2013tables/src/text/fmt/xp/fl_TableLayout.cpp
> ===================================================================
> --- abiword/branches/gsoc2013tables/src/text/fmt/xp/fl_TableLayout.cpp	2013-08-06 17:55:49 UTC (rev 33360)
> +++ abiword/branches/gsoc2013tables/src/text/fmt/xp/fl_TableLayout.cpp	2013-08-07 14:40:18 UTC (rev 33361)
> @@ -1686,7 +1686,7 @@
>  	s_background_properties (pszBgStyle, pszBgColor, pszBackgroundColor, m_background);
>  	
>  	//Table header
> -	char * pszTableHeader = NULL;
> +	char pszTableHeader[1024];
>   
>   	pSectionAP->getProperty("header",(const gchar *&)pszTableHeader);

I don't get why you changed the declaration of pszTableHeader. This is
actually bad because getProperty() will put a pointer into it.

Check the code in PP_AttrProp::getProperty() if you don't understand.


Hub