Re: serhat - r33376 - in abiword/branches/gsoc2013qt/src: af/ev/qt wp/ap/qt

On 11/08/13 07:05 AM, [email protected] wrote:
> +QPixmap
> +abi_pixmap_from_toolbar_id (const char *toolbar_id)
> +{

[...]

> +	while (stock_entries[i].abi_stock_id) 
> +	{
> +		if(!strcmp(stock_id, stock_entries[i].abi_stock_id))
> +		{
> +			QPixmap pixbuf(stock_entries[i].xpm_data);
> +			return pixbuf;
> +		}
> +		i++;
> +	}
> +
> +	// Should never reach here
> +	UT_ASSERT(0);
> +}


Serhat,

My problem here is that you never return anything. gcc emits a warning.
This should be fixed.


Hub