Re: jbrefort - r33970 - in abiword/trunk: . plugins/goffice plugins/mathview plugins/mathview/xp plugins/opendocument/common/xp plugins/opendocument/imp/xp src src/af/gr/xp src/af/xap/gtk src/text/fmt/xp src/text/ptbl/xp src/wp/ap/gtk src/wp/ap/xp src/wp/impexp/xp src/wp/test/xp

Hubert Figuière <[email protected]> Wed, 05 Mar 2014 00:36:49 -0500

Newsgroups	gmane.editors.abiword.devel
Message-ID	<[email protected]>

On 04/03/14 11:32 PM, Hubert Figuière wrote:

> I'd like to not have to install this by hand to just build AbiWord....
> 
> I think we should not require more than libgoffice-0.10 >= 0.10.0 in
> AbiWord configure and then only require that VERY recent version in the
> math plugin, so at least on can build without.
> 
> Otherwise there is no point of having this as a plugin.

Here is a proposed patch that :

1. set an older version as requirement for AbiWord

2. check for the proper version in the plugin.

Note: we still don't check of goffice has been built with lasem support.
We should.

Hub

config-fix.diff (text/x-patch, 789 B)

diff --git a/configure.ac b/configure.ac
index 4f25864..475c680 100644
--- a/configure.ac
+++ b/configure.ac
@@ -88,7 +88,7 @@ glib_req='glib-2.0 >= 2.6.0 gthread-2.0 >= 2.6.0 gobject-2.0 >= 2.6.0'
 gsf_req='libgsf-1 >= 1.14.18'
 gsf_gio_req='libgsf-1 >= 1.14.9'
 wv_req='wv-1.0 >= 1.2.0'
-goffice_req='libgoffice-0.10 >= 0.10.12'
+goffice_req='libgoffice-0.10 >= 0.10.0'
 xslt_req='libxslt'
 xp_pkgs="
   ${fribidi_req}
diff --git a/plugins/mathview/plugin.m4 b/plugins/mathview/plugin.m4
index 1bffdae..4ca16ce 100644
--- a/plugins/mathview/plugin.m4
+++ b/plugins/mathview/plugin.m4
@@ -1,5 +1,7 @@
 lasem=
 
+PKG_CHECK_EXISTS(libgoffice-0.10 >= 0.10.12, , [enable_mathview=no])
+
 if test "$enable_mathview" != ""; then
   dnl Only 0.4.1, or later will work
   for ver in 0.6 0.4 ; do