Re: Intent to release 3.0.1

--089e01175e5f891784050887cd9b
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 23, 2014 at 3:38 AM, Jean Br=C3=A9fort
<[email protected]> wrote:
>
> Hi,
>
> You don't need to assert in the getColor3D method, just returning false
> should work. Note that I think we should have implemented this default
> behavior  (as was done for the CairoNull_Graphics class instead of
> having a pure virtual method).
>
> Cheers,
> Jean

Thanks,  I had not had a chance to review where it is used.

>
> Le dimanche 23 novembre 2014 =C3=A0 00:06 -0500, [email protected] a
> =C3=A9crit :
>> On Wed, Nov 19, 2014 at 11:05 PM, Hubert Figui=C3=A8re <hfiguiere@teaser=
.fr> wrote:
>> >
>> > On 19/11/14 06:01 PM, [email protected] wrote:
>> >
>> >> I will do it this weekend if it isn't already done.  I haven't built
>> >> it in a while though, what is the preferred compiler version for
>> >> releases?
>> >
>> > If you don't mind doing it with the current 3.0 branch I'm willing to
>> > wait for feedback making sure we release 3.0.1 that you can build for
>> > Windows - in case something got broken.
>> >
>> > Thank you kindly.
>> >
>> > Hub
>> >
>>
>> I am still working on a successful Windows build; the attached patch
>> was what I needed to apply to get a completed build, however I am
>> still tracking down what went wrong as the program fails to start due
>> to a manifest sxs issue.
>>
>> Jeremy
>

This is an updated patch, it removes the assert and fixes the failure
to start.  I am building with MSVC 2010 pro on Windows 7; the manifest
version needs to be W.X.Y.Z form (the W.X.Y form is being flagged as
an invalid value and aborting startup).

I am still testing to ensure no major issues with build and I have
only started checking if dependencies are up to date.  With the
attached fixes (or similar) it should be fine to tag the release and
get a Windows build.

Jeremy

--089e01175e5f891784050887cd9b
Content-Type: text/plain; charset=US-ASCII; name="buildfix-try2.diff"
Content-Disposition: attachment; filename="buildfix-try2.diff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_i2uiehgf0

SW5kZXg6IGFmL2dyL3dpbi9ncl9XaW4zMkdyYXBoaWNzLmNwcA0KPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIGFm
L2dyL3dpbi9ncl9XaW4zMkdyYXBoaWNzLmNwcAkocmV2aXNpb24gMzUwMzMpDQorKysgYWYvZ3Iv
d2luL2dyX1dpbjMyR3JhcGhpY3MuY3BwCSh3b3JraW5nIGNvcHkpDQpAQCAtMTQwMCw2ICsxNDAw
LDExIEBADQogCV9zZXRDb2xvcihtXzNkQ29sb3JzW2NdKTsKIH0KIAorYm9vbCBHUl9XaW4zMkdy
YXBoaWNzOjpnZXRDb2xvcjNEKEdSX0NvbG9yM0QgbmFtZSwgVVRfUkdCQ29sb3IgJiBjbHIpCit7
CisJcmV0dXJuIGZhbHNlOworfQorCiB2b2lkIEdSX1dpbjMyR3JhcGhpY3M6OmluaXQzZENvbG9y
cyh2b2lkKQogewogCW1fM2RDb2xvcnNbQ0xSM0RfRm9yZWdyb3VuZF0gPSBHZXRTeXNDb2xvcihD
T0xPUl9CVE5URVhUKTsKSW5kZXg6IGFmL2dyL3dpbi9ncl9XaW4zMkdyYXBoaWNzLmgNCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0NCi0tLSBhZi9nci93aW4vZ3JfV2luMzJHcmFwaGljcy5oCShyZXZpc2lvbiAzNTAzMykN
CisrKyBhZi9nci93aW4vZ3JfV2luMzJHcmFwaGljcy5oCSh3b3JraW5nIGNvcHkpDQpAQCAtMjUy
LDYgKzI1Miw3IEBADQogCXZpcnR1YWwgdm9pZAkJCWhhbmRsZVNldEN1cnNvck1lc3NhZ2Uodm9p
ZCk7CiAKIAl2aXJ0dWFsIHZvaWQJCQlzZXRDb2xvcjNEKEdSX0NvbG9yM0QgYyk7CisJdmlydHVh
bCBib29sCQkJZ2V0Q29sb3IzRChHUl9Db2xvcjNEIC8qbmFtZSovLCBVVF9SR0JDb2xvciAmIC8q
Y29sb3IqLyk7CiAJdm9pZAkJCQkJaW5pdDNkQ29sb3JzKHZvaWQpOwogCXZpcnR1YWwgdm9pZAkJ
CWZpbGxSZWN0KEdSX0NvbG9yM0QgYywKIAkJCQkJCQkJCSBVVF9zaW50MzIgeCwgVVRfc2ludDMy
IHksCkluZGV4OiBhZi91dGlsL3hwL3V0X2dvX2ZpbGUuY3BwDQo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gYWYv
dXRpbC94cC91dF9nb19maWxlLmNwcAkocmV2aXNpb24gMzUwMzMpDQorKysgYWYvdXRpbC94cC91
dF9nb19maWxlLmNwcAkod29ya2luZyBjb3B5KQ0KQEAgLTExODgsOCArMTE4OCwxMCBAQA0KIAkJ
cmV0dXJuIHJlc3VsdDsKIAl9CiAKKyNpZmRlZiBXSVRIX0dTRl9JTlBVVF9IVFRQCiAJaWYgKCFz
dHJuY21wICh1cmksICJodHRwOi8vIiwgNykgfHwgIXN0cm5jbXAgKHVyaSwgImh0dHBzOi8vIiwg
OCkpCiAJCXJldHVybiBnc2ZfaW5wdXRfaHR0cF9uZXcgKHVyaSwgZXJyKTsKKyNlbmRpZgogI2lm
IEhBVkVfR1NGX0dJTwogCXJldHVybiBnc2ZfaW5wdXRfZ2lvX25ld19mb3JfdXJpICh1cmksIGVy
cik7CiAjZWxpZiBkZWZpbmVkKEdPRkZJQ0VfV0lUSF9HTk9NRSkKSW5kZXg6IHdwL21haW4vd2lu
L0FiaVdvcmQuZXhlLng4Ni5NQU5JRkVTVA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIHdwL21haW4vd2luL0Fi
aVdvcmQuZXhlLng4Ni5NQU5JRkVTVAkocmV2aXNpb24gMzUwMzMpDQorKysgd3AvbWFpbi93aW4v
QWJpV29yZC5leGUueDg2Lk1BTklGRVNUCSh3b3JraW5nIGNvcHkpDQpAQCAtMSw2ICsxLDYgQEAN
CiA8P3htbCB2ZXJzaW9uPSIxLjAiIGVuY29kaW5nPSJVVEYtOCIgc3RhbmRhbG9uZT0ieWVzIj8+
CiA8YXNzZW1ibHkgeG1sbnM9InVybjpzY2hlbWFzLW1pY3Jvc29mdC1jb206YXNtLnYxIiBtYW5p
ZmVzdFZlcnNpb249IjEuMCI+IAotPGFzc2VtYmx5SWRlbnRpdHkgdmVyc2lvbj0iMy4wLjk5IiBw
cm9jZXNzb3JBcmNoaXRlY3R1cmU9Ing4NiIgbmFtZT0iQWJpV29yZCIgCis8YXNzZW1ibHlJZGVu
dGl0eSB2ZXJzaW9uPSIzLjAuMC4wIiBwcm9jZXNzb3JBcmNoaXRlY3R1cmU9Ing4NiIgbmFtZT0i
QWJpV29yZCIgCiB0eXBlPSJ3aW4zMiIgLz4gCiA8ZGVwZW5kZW5jeT4gCiA8ZGVwZW5kZW50QXNz
ZW1ibHk+IAo=
--089e01175e5f891784050887cd9b--