Re: Patch for build error on Ubuntu LTS

Hubert Figuière <[email protected]> Tue, 6 Jun 2017 19:49:54 -0400
Newsgroups gmane.editors.abiword.devel
Message-ID <[email protected]>
On 06/06/17 02:58 PM, Jacob Mandelson wrote:
> Greetings abiword devs,
> 
> abiword 3.0.2 (latest release) fails to build on Ubuntu 16.04.2 LTS
> using g++ 5.4.0 with these fatal compile-time errors:
> 
> gr_UnixCairoGraphics.cpp:183:37: error: ‘nullptr’ was not declared in this scope
>   m_styleBg = XAP_GtkStyle_get_style(nullptr, "GtkButton"); // "button"
> gr_UnixCairoGraphics.cpp:630:30: error: ‘nullptr’ was not declared in this scope
>    GtkStyleContext *context = nullptr;
> 
> These errors are trivial to fix by replacing the undeclared 'nullptr'
> identifier with the literal '0', after which abiword builds and runs
> properly.  A patch that does this is attached.

Hi,

It is already in revision 35366

It was a mistake made when backporting patches, as trunk requires C++11
but not the 3.0.x branch.

Hub