Re: Choice does not work under link?

Christian Stocker <[email protected]> Mon, 13 Dec 2004 17:11:22 +0100
Newsgroups gmane.editors.bitflux.general
Message-ID <[email protected]>
Hi

On 13.12.2004 15:56 Uhr, Christian Stocker wrote:
> Hi
> 
> On 13.12.2004 15:34 Uhr, LiuCougar wrote:
> 
>> I wonder whether you could point out which file I should look at. I'd
>> like to investigate if you can somewhat narrow down the files...
> 
> 
> It's mainly in relaxng/AttributeVDOM.js but also in relaxng/ElementVDOM.js
> 
> But as I looked at it, I see that choice is basically implemented, at 
> least on the parsing side. There's just something missing in the 
> validating part. I'll try to figure it out. If you don't hear anything 
> from me in the next hour, I couldn't do it in a 5 minute hack ;)

It was more than a 5 minute hack. of course... That was another choice, 
I looked at. Anyway, it should now parse and validate 
<choice><attribute> constructs. If you find a bug, please report me.

The diff is here (if anyone's wondering, how it was done)
http://svnweb.bitflux.ch/horde/chora/diff.php/trunk?rt=svneditor&r1=1031&r2=1032&ty=u

The patch is of course in SVN.

One thing not working yet is editing this attributes. I'll do that right 
now.

chregu

> 
> chregu
> 
>>
>> Regards
>>
>>
>> On Mon, 13 Dec 2004 15:22:04 +0100, Christian Stocker 
>> <[email protected]> wrote:
>>
>>>
>>> On 13.12.2004 14:08 Uhr, LiuCougar wrote:
>>>
>>>> Hi,
>>>> Thanks for your quick response. I filed a bug (
>>>> http://bugzilla.bitflux.ch/show_bug.cgi?id=749 ).
>>>>
>>>> If you need any further information about the bug, I am more than
>>>> happy to provide.
>>>
>>>
>>> Thanks a lot. And I don't think I need more information, the bug is
>>> quite clear to me.
>>>
>>> I can't tell you, when it's fixed. I hope in the next few days. Should
>>> be an easy fix, but I'm busy with other stuff right now
>>>
>>> chregu
>>>
>>>
>>>
>>>
>>>> Regards,
>>>> Cougar
>>>>
>>>> On Mon, 13 Dec 2004 08:34:00 +0100, Christian Stocker 
>>>> <[email protected]> wrote:
>>>>
>>>>
>>>>> Hi
>>>>>
>>>>> On 13.12.2004 5:08 Uhr, LiuCougar wrote:
>>>>>
>>>>>
>>>>>> Hi all,
>>>>>> I am new to bitflux. First of all, I'd like to thanks all the authors
>>>>>> and contributors who make such a wonderful project publicly 
>>>>>> available.
>>>>>>
>>>>>> I use the SVN version of the bitflux and I am try to incorporate it
>>>>>> into ez publish (www.ez.no).
>>>>>
>>>>>
>>>>> Cool.
>>>>>
>>>>>
>>>>>
>>>>> I based my attemp on the inline example.
>>>>>
>>>>>
>>>>>> I changed the ulink to link (this is used in eZ) and it works fine:
>>>>>>   <define name="link">
>>>>>>       <element name="link">
>>>>>>           <attribute name="href"/>
>>>>>>           <optional>
>>>>>>           <attribute name="class"/>
>>>>>>           <attribute name="target"> <choice> <value>_self</value>
>>>>>> <value>_blank</value> </choice> </attribute>
>>>>>>           </optional>
>>>>>>           <ref name="Inline.model"/>
>>>>>>       </element>
>>>>>>   </define>
>>>>>> (I also changed the xml source file and the corresponding css file)
>>>>>>
>>>>>> However, when I incorporated an alternative required attribute id, it
>>>>>> stops working:
>>>>>>   <define name="link">
>>>>>>       <element name="link">
>>>>>>           <choice>
>>>>>>           <attribute name="href"/>
>>>>>>           <attribute name="id"/>
>>>>>>           </choice>
>>>>>>           <optional>
>>>>>>           <attribute name="class"/>
>>>>>>           <attribute name="target"> <choice> <value>_self</value>
>>>>>> <value>_blank</value> </choice> </attribute>
>>>>>>           </optional>
>>>>>>           <ref name="Inline.model"/>
>>>>>>       </element>
>>>>>>   </define>
>>>>>>
>>>>>> When I try to edit the xml file, I got the erros:
>>>>>> The attribute href is not allowed in link
>>>>>> #text is not allowed as child of link()
>>>>>
>>>>>
>>>>> yep. That's possible, that this is not supported right now. Attribute
>>>>> checking works a little bit different thant element checking.. Can you
>>>>> please file a bug under http://bugzilla.bitflux.ch/, I'll try to 
>>>>> have a
>>>>> look ASAP.
>>>>>
>>>>> Thanks for the report.
>>>>>
>>>>> chregu
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> The related xml source is:
>>>>>> If you can't wait to see it, just try our <link
>>>>>> href="../demo">demo</link> and have fun.
>>>>>>
>>>>>> Do you have any ideas? It seems to me that bitflux does not 
>>>>>> recongnize
>>>>>> the attributes under choice statement.
>>>>>>
>>>>>> Thanks in advance.
>>>>>>
>>>>>> Regards,
>>>>>> Cougar
>>>>>
>>>>>
>>>>> -- 
>>>>> christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
>>>>> phone +41 1 240 56 70 | mobile +41 76 561 88 60  | fax +41 1 240 56 71
>>>>> http://www.bitflux.ch  |  [email protected]  |  gnupg-keyid 0x5CE1DECB
>>>>>
>>>>
>>>>
>>>>
>>> -- 
>>> christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
>>> phone +41 1 240 56 70 | mobile +41 76 561 88 60  | fax +41 1 240 56 71
>>> http://www.bitflux.ch  |  [email protected]  |  gnupg-keyid 0x5CE1DECB
>>>
>>
>>
>>
> 

-- 
christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
phone +41 1 240 56 70 | mobile +41 76 561 88 60  | fax +41 1 240 56 71
http://www.bitflux.ch  |  [email protected]  |  gnupg-keyid 0x5CE1DECB
-- 
bx-editor-users mailing list
[email protected]
http://lists.bitflux.ch/cgi-bin/listinfo/bx-editor-users