Problems with class attributes (Was: Choice does not work under link?)

Christian Stocker <[email protected]> Mon, 13 Dec 2004 20:20:55 +0100
Newsgroups gmane.editors.bitflux.general
Message-ID <[email protected]> 

On 13.12.2004 20:04 Uhr, LiuCougar wrote:
> thanks for your info. Hope it can get sorted out soon.

The main problem here is, that we translate internally for example

<link href="foobar">
to
<span class="link" href="foobar">

The original class attribute gets lost ;) The idea was to make it easy 
to write your css for those elements:

.link { whatever you want here}

But now, we have to keep track of already existing class attributes... 
(and you have to adjust your css then)

one solution is to translate it to

<span class="link" href="foobar" __bxe_class="originalClass">

and then you have to adjust your maybe original CSS to

.originalClass, *[__bxe_class="originalClass"] {...}

whereever you want some class dependent styles

Would that be an ok solution? It only matters for you, if you need 
different styles for different classes.. Otherwise you don't have to 
adjust anything.

We can't touch the original approach, because of backwards compatibility.

If noone comes up with a better idea, I'll do that. But not today ;)

chregu

> 
> I really appreciate all your efforts. 
> 
> Best regards,
> Cougar
> 
> On Mon, 13 Dec 2004 19:39:04 +0100, Christian Stocker <[email protected]> wrote:
> 
>>
>>On 13.12.2004 19:35 Uhr, LiuCougar wrote:
>>
>>>thanks a lot. It works as expected now, except that I can not see the
>>>"class" attribute in the "edit attribute dialog", do you think this is
>>>normal?
>>
>>That's somehow a bug. I fixed it in some places. But obviously not
>>everywhere... And maybe not for non-XHTML elements... Have to check
>>that, but "class" attributes are known to have some issues ;)
>>
>>
>>
>>chregu
>>
>>
>>>Regards,
>>>
>>>
>>>On Mon, 13 Dec 2004 19:28:07 +0100, Christian Stocker <[email protected]> wrote:
>>>
>>>
>>>>Hi
>>>>
>>>>clear the cache in your browser. I had the same issues, but I fixed them
>>>>in the meantime. I found another problem on your website. Please do an
>>>>"svn up" and reload. hopefully should work now
>>>>
>>>>the "Edit link attributes.." should be fixed, as well
>>>>
>>>>chregu
>>>>
>>>>
>>>>
>>>>On 13.12.2004 19:16 Uhr, LiuCougar wrote:
>>>>
>>>>
>>>>>A minor issue is remaining (or it has not been implemented?):
>>>>>The "edit link attributes" dialog only contains the "target"
>>>>>attribute, plus a undefined one(you can see this at
>>>>>)
>>
>>
>>>>>A more serious issue is:
>>>>>If you move your mice to the "link" item in the right click menu (when
>>>>>you right click on the link, of course), a popup window is displayed:
>>>>>ERROR in Bitflux Editor:
>>>>>this_node has no properties
>>>>>In Files: ...
>>>>>
>>>>>(You can see the detail on the URL above).
>>>>>
>>>>>Or I misconfigured something?
>>>>>
>>>>>Regards,
>>>>>Cougar
>>>>>
>>>>>
>>>>>On Mon, 13 Dec 2004 17:59:02 +0000, LiuCougar <[email protected]> wrote:
>>>>>
>>>>>
>>>>>
>>>>>>yes!. Thanks a lot for your quick response and fix ;)
>>>>>>
>>>>>>Best wishes,
>>>>>>
>>>>>>
>>>>>>Cougar
>>>>>>
>>>>>>On Mon, 13 Dec 2004 18:52:15 +0100, Christian Stocker <[email protected]> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>>On 13.12.2004 18:17 Uhr, LiuCougar wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>Thanks for your quick fix. However I have to reopen this bug, for it
>>>>>>>>still does not work properly
>>>>>>>>(http://bugzilla.bitflux.ch/show_bug.cgi?id=749)
>>>>>>>
>>>>>>>Yep. true. Fixed. Hopefully
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>chregu
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>Regards,
>>>>>>>>Cougar
>>>>>>>>On Mon, 13 Dec 2004 17:11:22 +0100, Christian Stocker <[email protected]> wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>Hi
>>>>>>>>>
>>>>>>>>>On 13.12.2004 15:56 Uhr, Christian Stocker wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>Hi
>>>>>>>>>>
>>>>>>>>>>On 13.12.2004 15:34 Uhr, LiuCougar wrote:
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>>I wonder whether you could point out which file I should look at. I'd
>>>>>>>>>>>like to investigate if you can somewhat narrow down the files...
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>It's mainly in relaxng/AttributeVDOM.js but also in relaxng/ElementVDOM.js
>>>>>>>>>>
>>>>>>>>>>But as I looked at it, I see that choice is basically implemented, at
>>>>>>>>>>least on the parsing side. There's just something missing in the
>>>>>>>>>>validating part. I'll try to figure it out. If you don't hear anything
>>>>>>>>>
>>>>>>>>>>from me in the next hour, I couldn't do it in a 5 minute hack ;)
>>>>>>>>>
>>>>>>>>>It was more than a 5 minute hack. of course... That was another choice,
>>>>>>>>>I looked at. Anyway, it should now parse and validate
>>>>>>>>><choice><attribute> constructs. If you find a bug, please report me.
>>>>>>>>>
>>>>>>>>>The diff is here (if anyone's wondering, how it was done)
>>>>>>>>>http://svnweb.bitflux.ch/horde/chora/diff.php/trunk?rt=svneditor&r1=1031&r2=1032&ty=u
>>>>>>>>>
>>>>>>>>>The patch is of course in SVN.
>>>>>>>>>
>>>>>>>>>One thing not working yet is editing this attributes. I'll do that right
>>>>>>>>>now.
>>>>>>>>>
>>>>>>>>>chregu
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>chregu
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>>Regards
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>On Mon, 13 Dec 2004 15:22:04 +0100, Christian Stocker
>>>>>>>>>>><[email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>>On 13.12.2004 14:08 Uhr, LiuCougar wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>Hi,
>>>>>>>>>>>>>Thanks for your quick response. I filed a bug (
>>>>>>>>>>>>>http://bugzilla.bitflux.ch/show_bug.cgi?id=749 ).
>>>>>>>>>>>>>
>>>>>>>>>>>>>If you need any further information about the bug, I am more than
>>>>>>>>>>>>>happy to provide.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>Thanks a lot. And I don't think I need more information, the bug is
>>>>>>>>>>>>quite clear to me.
>>>>>>>>>>>>
>>>>>>>>>>>>I can't tell you, when it's fixed. I hope in the next few days. Should
>>>>>>>>>>>>be an easy fix, but I'm busy with other stuff right now
>>>>>>>>>>>>
>>>>>>>>>>>>chregu
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>Regards,
>>>>>>>>>>>>>Cougar
>>>>>>>>>>>>>
>>>>>>>>>>>>>On Mon, 13 Dec 2004 08:34:00 +0100, Christian Stocker
>>>>>>>>>>>>><[email protected]> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>>Hi
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>On 13.12.2004 5:08 Uhr, LiuCougar wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>Hi all,
>>>>>>>>>>>>>>>I am new to bitflux. First of all, I'd like to thanks all the authors
>>>>>>>>>>>>>>>and contributors who make such a wonderful project publicly
>>>>>>>>>>>>>>>available.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>I use the SVN version of the bitflux and I am try to incorporate it
>>>>>>>>>>>>>>>into ez publish (www.ez.no).
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>Cool.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>I based my attemp on the inline example.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>I changed the ulink to link (this is used in eZ) and it works fine:
>>>>>>>>>>>>>>><define name="link">
>>>>>>>>>>>>>>>   <element name="link">
>>>>>>>>>>>>>>>       <attribute name="href"/>
>>>>>>>>>>>>>>>       <optional>
>>>>>>>>>>>>>>>       <attribute name="class"/>
>>>>>>>>>>>>>>>       <attribute name="target"> <choice> <value>_self</value>
>>>>>>>>>>>>>>><value>_blank</value> </choice> </attribute>
>>>>>>>>>>>>>>>       </optional>
>>>>>>>>>>>>>>>       <ref name="Inline.model"/>
>>>>>>>>>>>>>>>   </element>
>>>>>>>>>>>>>>></define>
>>>>>>>>>>>>>>>(I also changed the xml source file and the corresponding css file)
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>However, when I incorporated an alternative required attribute id, it
>>>>>>>>>>>>>>>stops working:
>>>>>>>>>>>>>>><define name="link">
>>>>>>>>>>>>>>>   <element name="link">
>>>>>>>>>>>>>>>       <choice>
>>>>>>>>>>>>>>>       <attribute name="href"/>
>>>>>>>>>>>>>>>       <attribute name="id"/>
>>>>>>>>>>>>>>>       </choice>
>>>>>>>>>>>>>>>       <optional>
>>>>>>>>>>>>>>>       <attribute name="class"/>
>>>>>>>>>>>>>>>       <attribute name="target"> <choice> <value>_self</value>
>>>>>>>>>>>>>>><value>_blank</value> </choice> </attribute>
>>>>>>>>>>>>>>>       </optional>
>>>>>>>>>>>>>>>       <ref name="Inline.model"/>
>>>>>>>>>>>>>>>   </element>
>>>>>>>>>>>>>>></define>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>When I try to edit the xml file, I got the erros:
>>>>>>>>>>>>>>>The attribute href is not allowed in link
>>>>>>>>>>>>>>>#text is not allowed as child of link()
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>yep. That's possible, that this is not supported right now. Attribute
>>>>>>>>>>>>>>checking works a little bit different thant element checking.. Can you
>>>>>>>>>>>>>>please file a bug under http://bugzilla.bitflux.ch/, I'll try to
>>>>>>>>>>>>>>have a
>>>>>>>>>>>>>>look ASAP.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>Thanks for the report.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>chregu
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>The related xml source is:
>>>>>>>>>>>>>>>If you can't wait to see it, just try our <link
>>>>>>>>>>>>>>>href="../demo">demo</link> and have fun.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>Do you have any ideas? It seems to me that bitflux does not
>>>>>>>>>>>>>>>recongnize
>>>>>>>>>>>>>>>the attributes under choice statement.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>Thanks in advance.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>Regards,
>>>>>>>>>>>>>>>Cougar
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>--
>>>>>>>>>>>>>>christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
>>>>>>>>>>>>>>phone +41 1 240 56 70 | mobile +41 76 561 88 60  | fax +41 1 240 56 71
>>>>>>>>>>>>>>http://www.bitflux.ch  |  [email protected]  |  gnupg-keyid 0x5CE1DECB
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>--
>>>>>>>>>>>>christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
>>>>>>>>>>>>phone +41 1 240 56 70 | mobile +41 76 561 88 60  | fax +41 1 240 56 71
>>>>>>>>>>>>http://www.bitflux.ch  |  [email protected]  |  gnupg-keyid 0x5CE1DECB
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>--
>>>>>>>>>christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
>>>>>>>>>phone +41 1 240 56 70 | mobile +41 76 561 88 60  | fax +41 1 240 56 71
>>>>>>>>>http://www.bitflux.ch  |  [email protected]  |  gnupg-keyid 0x5CE1DECB
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>--
>>>>>>>christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
>>>>>>>phone +41 1 240 56 70 | mobile +41 76 561 88 60  | fax +41 1 240 56 71
>>>>>>>http://www.bitflux.ch  |  [email protected]  |  gnupg-keyid 0x5CE1DECB
>>>>>>>
>>>>>>
>>>>>>--
>>>>>>"People's characters are strengthened through struggle against
>>>>>>difficulties; they are weakened by comfort."
>>>>>>- Old Chinese adage
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>--
>>>>christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
>>>>phone +41 1 240 56 70 | mobile +41 76 561 88 60  | fax +41 1 240 56 71
>>>>http://www.bitflux.ch  |  [email protected]  |  gnupg-keyid 0x5CE1DECB
>>>>
>>>
>>>
>>>
>>--
>>christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
>>phone +41 1 240 56 70 | mobile +41 76 561 88 60  | fax +41 1 240 56 71
>>http://www.bitflux.ch  |  [email protected]  |  gnupg-keyid 0x5CE1DECB
>>
> 
> 
> 

-- 
christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
phone +41 1 240 56 70 | mobile +41 76 561 88 60  | fax +41 1 240 56 71
http://www.bitflux.ch  |  [email protected]  |  gnupg-keyid 0x5CE1DECB
-- 
bx-editor-users mailing list
[email protected]
http://lists.bitflux.ch/cgi-bin/listinfo/bx-editor-users