[patch] change of icon in the "validation" fails window
Douglas Burke <[email protected]>
| Newsgroups | gmane.editors.conglomerate.devel |
|---|---|
| Message-ID | <Pine.GSO.4.58.0410121904520.8733@lagado> |
I keep on getting caught by the fact the informational window generated by the "Tools/Validate Document" menu item uses the same icon (a lightbulb) whether the validation was a success or not. The attached patch against CVS changes the "on failure" case to use http://developer.gnome.org/doc/API/2.0/gtk/gtk-Stock-Items.html#GTK-STOCK-DIALOG-ERROR-CAPS rather than http://developer.gnome.org/doc/API/2.0/gtk/gtk-Stock-Items.html#GTK-STOCK-DIALOG-INFO-CAPS I haven't read the Gnome HIG to see if this is a "sensible" change, but I can't se why it wouldn't be. Doug
cong.diff
(text/plain, 1.3 KB)
Index: src/ChangeLog =================================================================== RCS file: /cvs/gnome/conglomerate/src/ChangeLog,v retrieving revision 1.725 diff -u -r1.725 ChangeLog --- src/ChangeLog 10 Oct 2004 19:36:50 -0000 1.725 +++ src/ChangeLog 12 Oct 2004 23:03:24 -0000 @@ -1,3 +1,10 @@ +2004-10-12 Douglas Burke <[email protected]> + + * plugin-validate.c + + The icon used when there is an error is now different than when + the document validates. + 2004-10-10 Dave Malcolm <[email protected]> * cong-plugin.c: Index: src/plugin-validate.c =================================================================== RCS file: /cvs/gnome/conglomerate/src/plugin-validate.c,v retrieving revision 1.14 diff -u -r1.14 plugin-validate.c --- src/plugin-validate.c 25 Jun 2004 00:33:03 -0000 1.14 +++ src/plugin-validate.c 12 Oct 2004 23:03:24 -0000 @@ -117,7 +117,7 @@ text_view = gtk_text_view_new_with_buffer (buffer); title = g_strdup_printf ("Document \"%s\" is not valid", doc_name); - alert = cong_alert_content_new (GTK_STOCK_DIALOG_INFO, title, NULL, NULL); + alert = cong_alert_content_new (GTK_STOCK_DIALOG_ERROR, title, NULL, NULL); g_free (title); expander = gtk_expander_new_with_mnemonic ("_Details");