Re: [patch] change of icon in the "validation" fails window

David Malcolm <[email protected]>
Newsgroups gmane.editors.conglomerate.devel
Message-ID <[email protected]>
On Tue, 2004-10-12 at 19:09 -0400, Douglas Burke wrote:
> I keep on getting caught by the fact the informational window generated by
> the "Tools/Validate Document" menu item uses the same icon (a lightbulb)
> whether the validation was a success or not. The attached patch against
> CVS changes the "on failure" case to use
> 
> http://developer.gnome.org/doc/API/2.0/gtk/gtk-Stock-Items.html#GTK-STOCK-DIALOG-ERROR-CAPS
> 
> rather than
> 
> http://developer.gnome.org/doc/API/2.0/gtk/gtk-Stock-Items.html#GTK-STOCK-DIALOG-INFO-CAPS
> 
> I haven't read the Gnome HIG to see if this is a "sensible" change, but I
> can't se why it wouldn't be.

Seems sensible enough to me, and I think it's a definite visual
improvement; I've committed this.  Thanks!

Dave
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.