Re: [patch] minor change to internals of cong-attribute-editor-enumeration.c
David Malcolm <[email protected]>
| Newsgroups | gmane.editors.conglomerate.devel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 2004-10-14 at 12:29 -0400, Douglas Burke wrote: > The attached patch switches to using a GPtrArray to store/access the > enumerated values for an attribute, rather than directly access the > xmlAttributePtr. There's not much in it - in terms of code simplicity - > between the two approaches. I made the change because it matches the > approach used by the other ComboBox's (i.e. changes made yesterday), and > because of bug # 122028 - i.e. > http://bugzilla.gnome.org/show_bug.cgi?id=122028 > - although I'm not sure it is really relevant here (since the widget > should be re-created if there is a DTD change). Seems like a sane cleanup, and looks like good progress towards fixing 122028; I tested this and it worked for me, so I've committed it - thanks. So what more work is needed to fix 122028? Probably worth cataloging the problem areas (if any) in that bug. Dave