Re: patch for bug 443 (ENCODE-UNIVERSAL-TIME effectively ignores TIME-ZONE argument)

On 4/17/17 02:03, Scott L. Burson wrote:
> On Sat, Apr 15, 2017 at 10:35 PM, Mark Evenson <[email protected]> wrote:
>>
>> On 4/16/17 01:08, Robert Dodier wrote:
>>> Hi, here is a patch to fix bug 443. With this change, Maxima + ABCL
>>> passes its tests (in tests/rtest11.mac for the record) for
>>> parse_timedate which calls ENCODE-UNIVERSAL-TIME.
>>
>> Thanks for the patch; it has been applied as [r14995][].
>>
>> [r14995]: http://abcl.org/trac/changeset/14995
>>
>>> Incidentally this patch also fixes an unreported bug in
>>> DECODE-UNIVERSAL-TIME: the daylight saving flag is reported
>>> incorrectly because EXT:GET-TIME-ZONE expects its argument in
>>> milliseconds, not seconds.
> 
> The patch I submitted did not have either of these bugs.  The
> ENCODE-UNIVERSAL-TIME bug was a merge error: the original had two very
> similar lines, in the first and third COND clause, and the hunk was
> intended for the third clause but was applied to the first.  A close
> look at the emailed patch will confirm this.
> 
> And then you intentionally changed GET-TIME-ZONE to take a Unix time
> in milliseconds rather than a universal time, and didn't fix the call
> sites.  (I don't agree with the change in interface; I think CL
> functions should use universal times whenever possible.)

[…]

My apologies: it seems that I am indeed largely at fault for misapplying
and misunderstanding Scott's original patch.  Thanks for the more
detailed explanation.

I'll get some coffee, and attempt re-examine the problem with wider eyes.




-- 
"A screaming comes across the sky.  It has happened before, but there
is nothing to compare to it now."