Re: Patch for a couple of stack inconsistency bugs

Mark Evenson <[email protected]> Sat, 16 Nov 2019 15:45:48 +0100
Newsgroups gmane.editors.j.devel
Message-ID <72ABAD11-F095-40EA-8315-F4DEB3C95E7A__42152.444743418$1573915569$gmane$org@panix.com>

> On May 31, 2019, at 23:49, Mark Evenson <[email protected]> wrote:
> 
> 
> 
>> On May 29, 2019, at 15:21, somewhat-functional-programmer <[email protected]> wrote:
>> 
>> Hello list,
>> 
>> Lately I have been starting to dive deeper into Common Lisp and have started to
>> use ABCL more than SBCL or CCL lately. It is a very impressive project.
>> 
> Thanks.  Welcome!
> 
>> Let me know what you think, and again please review, there aren't many lines
>> changed but I am new to the internals of the project. I think I ran all tests
>> (ant abcl.test) but while the ant task completed successfully, my output
>> complained of a missing dependency and I'm not sure what actually ran.
> 
> Initial testing of your patch looks good, in that it makes sense as a patch and that it doesn’t seem to break anything obvious under both java-8 and java-11.  I will try to incorporate into the mainline repos soonish.  
> 
> Best,
> Mark <[email protected]>
> 
> 
> -- 
> "A screaming comes across the sky.  It has happened before but there is nothing 
> to compare to it now."
> 
> 
> 
> 
> 
> 

Thanks ever so-much for the patch!  [It will be part of abcl-1.6.0][1] 


[1]: https://gitlab.common-lisp.net/abcl/abcl/commit/cd0b2f356330e41ced7c2df84789eee88cd94d59

-- 
"A screaming comes across the sky.  It has happened before but there is nothing 
to compare to it now."