[LyX/master] Do not open inset settings when click happened elsewhere (#13340)

Juergen Spitzmueller <[email protected]> Sun, 28 Jun 2026 13:46:06 +0000
Newsgroups gmane.editors.lyx.cvs
Message-ID <[email protected]>
commit b26be315f2fa2463ff5b11a014c8585146855499
Author: Juergen Spitzmueller <[email protected]>
Date:   Sun Jun 28 15:45:26 2026 +0200

    Do not open inset settings when click happened elsewhere (#13340)
---
 src/insets/Inset.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/insets/Inset.cpp b/src/insets/Inset.cpp
index 806c772da6..d9e28f31a5 100644
--- a/src/insets/Inset.cpp
+++ b/src/insets/Inset.cpp
@@ -452,9 +452,9 @@ void Inset::doDispatch(Cursor & cur, FuncRequest &cmd)
 		// we assume we request the settings dialog,
 		// except if we are about to select (MOUSE_MOTION that started
 		// outside the inset).
-		if ((!cur.selection() || covers(cur.bv(), cur.bv().cursor().xClickPos(),
-						cur.bv().cursor().yClickPos()))
-		    && cmd.button() == mouse_button::button1
+		if (cmd.button() == mouse_button::button1
+		    && covers(cur.bv(), cur.bv().cursor().xClickPos(),
+			      cur.bv().cursor().yClickPos())
 		    && clickable(cur.bv(), cmd.x(), cmd.y()) && hasSettings()) {
 			FuncRequest tmpcmd(LFUN_INSET_SETTINGS);
 			dispatch(cur, tmpcmd);
-- 
lyx-cvs mailing list
[email protected]
https://lists.lyx.org/mailman/listinfo/lyx-cvs