Re: Compile error with newest master

Kornel Benko <[email protected]> Thu, 19 Feb 2026 12:45:44 +0100

Newsgroups	gmane.editors.lyx.devel
Message-ID	<20260219124544.3c019cb2@admin1-desktop>

Am Thu, 19 Feb 2026 12:16:14 +0100
schrieb "Jürgen Spitzmüller" <[email protected]>:

> Am Donnerstag, dem 19.02.2026 um 11:55 +0100 schrieb Jürgen 
> > And it also makes this suggestion in other (older) classes
> > apparently.  
> 
> As to -Wshadow the compiler barks at multiple places. This seems to be
> fixable easily if we think it is worth it. E.g. in the case included in
> this report

Yes, I omit '-Wshadow' for many files already.

> diff --git a/src/support/Changer.h b/src/support/Changer.h
> index 8cd04894c8..034ec70d95 100644
> --- a/src/support/Changer.h
> +++ b/src/support/Changer.h
> @@ -37,7 +37,7 @@ using Changer = std::unique_ptr<Revertible>;
>  template<typename X>
>  class RevertibleRef : public Revertible {
>  public:
> -       RevertibleRef(X & ref) : ref(ref), old(ref), enabled(true) {}
> +       RevertibleRef(X & r) : ref(r), old(r), enabled(true) {}
>         //
>         ~RevertibleRef() override { revert(); }
>         //
> 
> 
> But this has certainly not been introduced by ae917831438

Yes, the file InsetDynamicArgs.cpp is new, so I was not omitting some warnings there.

	Kornel

-- 
lyx-devel mailing list
[email protected]
https://lists.lyx.org/mailman/listinfo/lyx-devel

signature.asc (application/pgp-signature, 488 B)