Re: [LyX/master] Move input method debug messages to Debug::KEY category
Koji Yokota <[email protected]>
| Newsgroups | gmane.editors.lyx.devel |
|---|---|
| Message-ID | <[email protected]> |
> 2026/04/10 17:59、Jean-Marc Lasgouttes <[email protected]>のメール: > >> #ifdef _DEBUG >> - LYXERR(Debug::DEBUG, "GuiInputMethod: Address of parent: " << parent); >> - LYXERR(Debug::DEBUG, "GuiInputMethod: Address of buffer_view_: " << >> + LYXERR(Debug::KEY, "GuiInputMethod: Address of parent: " << parent); >> + LYXERR(Debug::KEY, "GuiInputMethod: Address of buffer_view_: " << >> &d->work_area_->bufferView()); >> #endif > > Koji, why the #ifdef _DEBUG? It defeats the whole logic of runtime selection of debug messages. I might be too anxious about time efficiency. Am I right that LYXERR at least undertakes conditional check at run time? It might be very short time but my worry is that typing can be very sensitive to time lag (and also I have inserted too many debug codes). Those abundant debug messages are very useful at debug time to know what kind of communication is going on between application and the system (you know, we don’t know it a priori), but I’m concerned if it can be a burden in a release mode. Koji -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel