Re: [PATCH] build: enable maintainer mode

Mike Frysinger <[email protected]> Tue, 1 Mar 2022 20:45:19 -0500

Newsgroups	gmane.editors.nano.devel
Message-ID	<Yh7ML/7MpftbCMFi@vapier>

On 01 Mar 2022 10:55, Benno Schulenberg wrote:
> Op 26-02-2022 om 08:10 schreef Mike Frysinger:
> > This disable regeneration of autotools by default (e.g. autoconf &
> > automake) when running `make`.  The few maintainers that want this
> > can re-enable with `./configure --enable-maintainer-mode`.
> 
> > +AM_MAINTAINER_MODE
> 
> If I apply this patch, run make, and then apply your next patch and
> run make, then nano gets miscompiled, because configure does not get
> rebuilt and rerun, and thus HAVE_CHOWN and HAVE_FORK and such do not
> get defined in config.h, so that several pieces of code do not get
> included in the binary.  I think this is wrong.  I think the build
> rules should do the right thing by default.  Only if someone wants to
> take shortcuts (to reduce the build time and risk misbuilds), they
> should be able to run ./configure with --disable-maintainer-mode.

this model makes sense when building from git, but can get into trouble
when using releases when hitting timestamp skew.  in general, forcing
autotools to run from a release tarball is not a good default.

> So would adding 'AM_MAINTAINER_MODE([enable])' work for you?

if you want
-mike

signature.asc (application/pgp-signature, 833 B)