Re: [PATCH] new feature: horizontal scrolling of full screen

Benno Schulenberg <[email protected]> Wed, 7 Jan 2026 16:18:34 +0100

Newsgroups	gmane.editors.nano.devel
Message-ID	<[email protected]>

Op 07-01-2026 om 00:17 schreef Xylia Allegretta:
> That's a pretty easy change. I've added a check for if JUMPY_SCROLLNG is
> set in the scrolling update function, and eliminated a variable in winio that
> I realized was unnecessary.

With your patch applied, run `src/nano +89 doc/faq.html` and search
for the string "interface" (without the quotes).  See how for the
first two findings only "int" is briefly spotlighted and "erface"
is offscreen to the right.

Then repeatedly search for "also" (without the quotes).  You'll see
that three times only "als" is spotlighted.  [This isn't too bad:
see how this repeated search fares in `micro` or `tilde`: two or
three times the found occurrence is fully offscreen to the left.]

However, did you see the "smooth horizontal scrolling" patch that I
posted three days ago?  It wasn't meant as an additional patch to
yours, but as an alternative.  What do you think of it?  In my eyes
it is simpler and easier to understand.  And much shorter too.  The
current version of your patch adds more than a hundred lines, whereas
the second version of my patch, which I'll post in a few minutes, adds
just over 40 lines.  This is the implementation I intend to merge.
Do you see any issues with it?  If yes, which?  And are there any
reasons why your implementation would be preferable?


Benno

OpenPGP_signature.asc (application/pgp-signature, 840 B)