[poedit-users] Empty automatic comments being deleted

Olivier <[email protected]>
Newsgroups gmane.editors.poedit.user
Message-ID <[email protected]>
Hi

As people in the company I'm working for are starting to use poedit on a 
daily basis, they notice a few glitches. Most of them I fix them myself 
and propose a patch. This explains the 6 new patches in the past week or so.
However, there is a one of these glitches that I would like your opinion 
about:

When parsing elements, the CatalogParser class ignores empty '#.' lines 
which means that some automatic comments get stripped from the file when 
saving. I know that empy lines are almost meaningless, but this makes 
quite a lot of differences when putting a file back into our source 
control system.
These empty lines come from comments developers put in the source code 
and that get picked up by our overnight extraction mechanism. In some 
instances, those empty lines are intentional, to "air up" the explanations.

I've got a patch ready that basically removes the line == _T("#.") from 
the test on line 364 in catalog.cpp and adds a new call to ReadParam 
alongside the one with _T("#. ")

I'm ready to submit that patch, I'm just curious to disccus this point 
with you first.

Cheers

Olivier Sannier


-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.