Re: [PATCH] Shut up valgrind

On 23 janv. 2014, at 14:40, François Revol <[email protected]> wrote:

> On 23/01/2014 14:02, Charles Gordon wrote:
>> Hi Francois,
>> 
>> I just committed a large patch to fix this issue among other malloc related inconsistencies.
>> valgrind was right, it was a bug!
>> qe_mallocz would have cleared the allocated structure, but you used malloc in haiku.cpp to allocate it :(
>> valgrind rules!
> 
> Actually I ran it on GNU/Linux since valgrind isn't available yet on
> Haiku... (I just started the port).
> The X11 code did use qe_mallocz, but I didn't check the tty code though.

Then this issue is unresolved.
I fixed most memory leaks using valgrind, but I cannot test x11 on Linux for the moment.

>> I added macros to prevent spurious uses of malloc/free.
>> Can you verify the I did not break the compilation?
> 
> Works on Debian here.
> 
> On Haiku I had to change some atomic calls since the API has been
> modified recently, but the rest seems ok.

I just committed your patch.

Thank you

Chqrlie.