Re: Merge request for added QtQuick/QML support for Scintilla and SciteQt implementation
"'Neil Hodgson' via scite-interest" <[email protected]>
| Newsgroups | gmane.editors.scite.general |
|---|---|
| Message-ID | <[email protected]> |
Michael Neuroth: > - scintilla\include\Platfrom.h // 7 lines added: Added a define for the new platform: PLAT_QT_QML, The PLAT_QT_QML definition is fine. Committed. > typedef for PainterID, new overload for method init() in Surface class Are these really needed for the SurfaceID-free constructor which is used for measuring text? Can’t the value be retrieved from the WindowID that is passed into Init? Perhaps a global WindowID->QQuickPaintedItem map. > - scite\src\SciTEProps.cxx // 1 line: additional define check to support more target platforms OK, committed. > Optional patches (needed for support to show the full path of the file as a tooltip over the tabbutton of the edit page): > - scite\src\GUI.h // 1 line: additional define checks to support more target platforms 5 cases so probably better to check the other way round for just _WIN32. For TabInsert, the full path can be found from the index with buffers.buffers[index].file. > - scite\src\SciTEBase.h // 2 lines modified & marked Save() method as virtual, needed for Android OK, committed. Neil -- You received this message because you are subscribed to the Google Groups "scite-interest" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/scite-interest/3F0F4861-2190-4AC2-87D9-EAA2E997BECE%40me.com.