Re: crash
Neil Hodgson <[email protected]> Thu, 17 Oct 2024 16:32:07 -0700 (PDT)
| Newsgroups | gmane.editors.scite.general |
|---|---|
| Message-ID | <[email protected]> |
------=_Part_37440_383569042.1729207927165 Content-Type: multipart/alternative; boundary="----=_Part_37441_817382131.1729207927165" ------=_Part_37441_817382131.1729207927165 Content-Type: text/plain; charset="UTF-8" - open attached file - hold the DOWNARROW key or scroll down with the mouse scroll wheel or scroll bar up to the point as shown in CrashDialog.png This occurs with Unix-style \n line ends but doesn't (or is less likely) with Windows \r\n line ends and it depends on the range being styled so may not happen if (for example) you move straight to the file end then move back to this position. The bug is actually in handling an empty document comment keyword. Some document comment tools use XML like tags such as <summary>. The code sees the < and then checks the next text against the defined keywords. There are other potential results here: if the document is scrolled to the end to avoid the crash then the line after the '<' is changed then the rest of the document may appear as an invalid documentation comment keyword. A reasonable fix appears to be to not treat a '<' followed by whitespace like a line and as the start of a keyword, so that has been committed as. https://github.com/ScintillaOrg/lexilla/commit/5bd3f0fa390aaad1901d1d84e577b1c8bf9e5003 An updated binary is available from https://www.scintilla.org/wscite.zip Windows executable (64-bit) Due to this change the releases will be delayed so may appear tomorrow October 19 instead of today. Neil -- You received this message because you are subscribed to the Google Groups "scite-interest" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/scite-interest/deaef189-eb64-432e-8b00-5fe4e7f5ee77n%40googlegroups.com. ------=_Part_37441_817382131.1729207927165 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div><blockquote style=3D"margin: 0px 0px 0px 0.8ex; border-left-width: 1px= ; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-= left: 1ex;"><div>=C2=A0- open attached file</div><div>=C2=A0- hold the=C2= =A0<span style=3D"background-color: rgb(249, 249, 249); color: rgb(0, 0, 0)= ; font-family: sans-serif; font-size: 12.7px;">DOWNARROW key or scroll down= with the mouse scroll wheel or scroll bar up to the point as shown in=C2= =A0</span>CrashDialog.png</div></blockquote><div><br /></div><div>This occu= rs with Unix-style \n line ends but doesn't (or is less likely) with Window= s \r\n line ends and it depends on the range being styled so may not happen= if (for example) you move straight to the file end then move back to this = position.</div><div><br /></div><div>The bug is actually in handling an emp= ty document comment keyword. Some document comment tools use XML like tags = such as <summary>. The code sees the < and then checks the next te= xt against the defined keywords. There are other potential results here: if= the document is scrolled to the end to avoid the crash then the line after= the '<' is changed then the rest of the document may appear as an inval= id documentation comment keyword.</div><div><br /></div><div>A reasonable f= ix appears to be to not treat a '<' followed by whitespace like a line a= nd as the start of a keyword, so that has been committed as.</div><div>http= s://github.com/ScintillaOrg/lexilla/commit/5bd3f0fa390aaad1901d1d84e577b1c8= bf9e5003<br /></div><div><br /></div>An updated binary is available from<br= /> <a href=3D"https://www.scintilla.org/wscite.zip">https://www.scintilla.= org/wscite.zip</a> Windows executable (64-bit)<br /><br />Due to this chang= e the releases will be delayed so may appear tomorrow October 19 instead of= today.<br /><br />Neil</div> <p></p> -- <br /> You received this message because you are subscribed to the Google Groups &= quot;scite-interest" group.<br /> To unsubscribe from this group and stop receiving emails from it, send an e= mail to <a href=3D"mailto:[email protected]">scit= [email protected]</a>.<br /> To view this discussion on the web visit <a href=3D"https://groups.google.c= om/d/msgid/scite-interest/deaef189-eb64-432e-8b00-5fe4e7f5ee77n%40googlegro= ups.com?utm_medium=3Demail&utm_source=3Dfooter">https://groups.google.com/d= /msgid/scite-interest/deaef189-eb64-432e-8b00-5fe4e7f5ee77n%40googlegroups.= com</a>.<br /> ------=_Part_37441_817382131.1729207927165-- ------=_Part_37440_383569042.1729207927165--