Re: [vim/vim] Refined autoload mechanism explanation (PR #20833)

ubaldot left a comment (vim/vim#20833)

> Two formatting points on the new text.
> 
> Lines are wrapped earlier than they need to be. The file has `textwidth=78` in its modeline, and the convention is to fill up to it, so a line should not be broken while the next word still fits, unless the break is intentional. Some examples, with the width of the line and what the next word would make it:
> 
> ```
> 	139  ... an imported script is                        65 -> 72
> 	146  ... of an imported script may                    66 -> 69
> 	148  keyword.                                          8 -> 14
> 	152  Nothing in the rest of the script needs to change. 50 -> 59
> 	175  under 'runtimepath'.                              20 -> 25
> 	184  ... in 'runtimepath', choose                      71 -> 73
> ```
> 
> There are about 15 such lines in the added paragraphs. Rather than fixing them by hand, let Vim reflow the paragraph: `gqip` in Normal mode, `gq` on a Visual selection, `gqq` for a single line. It picks up `textwidth=78` from the modeline, and 'joinspaces' is on by default so the two spaces between sentences are kept.
> 
> By the way, there is still one single space after a full stop left, at line 217. `gq` will not catch that one, it is mid-line.

All the points have been addressed. 

@chrisbra sorry if I am a bit blunt here, but from the evidence emerged during the reviewing process of this PR, I feel in charge to highlight that a community that (facts):

- Accepts AI-generated reviews without proper verification,
- Misses technical distinctions but insists on formatting,
- Makes contributors chase trivialities after substantive work,

is a community that is kinda losing its way. 


-- 
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/20833#issuecomment-5091843229
You are receiving this because you are subscribed to this thread.

Message ID: <vim/vim/pull/20833/[email protected]>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/20833/c5091843229%40github.com.