Re: [vim/vim] Refined autoload mechanism explanation (PR #20833)

h-east left a comment (vim/vim#20833)

A quick final commit from your side is fine, that is what I was asking for. No
follow-up PR needed.

On "we're down to line wrapping and spacing": of the five inline comments, three
were about content, and you applied them all. `autoload import` corrected
to `import autoload` at 169, the sentence about types restored at 153, and the
sentence at 213. A reader copying line 169 as it stood would have got an error.

The wrapping is still open. 14 lines in the added paragraphs break while the
next word would fit, including 139, 146, 148, 175 and 184, the ones I listed by
number. `gqip` per paragraph handles it.

On the "fundamental misunderstanding": the sentence you quoted from my first
review was about the `did_load` guard, not a claim that the two examples are
equivalent. The same paragraph identified `export var did_load = false` running
its initialiser again as the reason your test printed what it did, and said the
documented idiom guards on existence instead. That is
the distinction you then spent several comments explaining back to me. Placing
`vim9-reload` next to 52.4 invited it, but it was a misreading, not a
misunderstanding on my side. The conclusion held, and I posted a script you can
run to check it.

My first review opened with "(I used Claude Code for assistance, but I've
reviewed and verified the contents myself.)" That was accurate. I check what the
tool produces, and where a claim needs checking I write a script and run it, as
I did here. Humans and tools both get things wrong, as your reading of that
sentence shows. Because a tool is involved I work with extra care, so that the
work is not dismissed for that reason alone. If none of that came through in
this exchange, that is genuinely disappointing.

That is as far as I want to take this. The merge decision is @chrisbra's.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/20833#issuecomment-5093883392
You are receiving this because you are subscribed to this thread.

Message ID: <vim/vim/pull/20833/[email protected]>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/20833/c5093883392%40github.com.