Re: [vim/vim] Add hardcopy print backend using Pango + Cairo (PR #20648)

64-bitman left a comment (vim/vim#20648)

> The following lines: if (n > 0 && (size_t)(gap->ga_len + n) > SIZE_MAX / gap->ga_itemsize)
> 
> If gap->ga_itemsize is 0, this can lead to Divide by zero. ga_itemsize is, typically set once via ga_init2(gap, itemsize, growsize) when the array is initialized. There is no check against this value of 0 tho.

Well this is unrelated to this PR. the item size should always be greater than zero, if not then thats a programmer error

-- 
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/20648#issuecomment-5109954700
You are receiving this because you are subscribed to this thread.

Message ID: <vim/vim/pull/20648/[email protected]>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/20648/c5109954700%40github.com.