[vim/vim] screen line is lost when splitting a 'winfixheight' window (PR #20871)

```
Problem:  When the only window has 'winfixheight' set and 'laststatus'
          is one, splitting it leaves one screen line unused.  This
          happens for example when jumping to an item from a maximized
          quickfix window.
Solution: Do not subtract the height of the status line twice.
```

fixes: #20495

---

The report asks for the same handling as 9.2.0581 in qf_jump*, but this
is not specific to quickfix.  Any window reproduces it: >
      :setlocal winfixheight
      :split
The quickfix window only stands out because ":copen" sets
'winfixheight' for you.

The height requested from win_setheight_win() already includes room for
the status line, and win_setheight_win() fits the result into the frame,
so subtracting the status line height again loses one line.  This only
shows when the window has no status line yet, which is the case when it
is the only window and 'laststatus' is one, and then the window can
never grow, so the line is always lost.

make test_window_cmd and make test_quickfix pass.
You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20871

-- Commit Summary --

  * screen line is lost when splitting a 'winfixheight' window

-- File Changes --

    M src/testdir/test_window_cmd.vim (17)
    M src/window.c (3)

-- Patch Links --

https://github.com/vim/vim/pull/20871.patch
https://github.com/vim/vim/pull/20871.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/20871
You are receiving this because you are subscribed to this thread.

Message ID: <vim/vim/pull/[email protected]>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/20871%40github.com.