Re: [vim/vim] runtime(zip): Customizable zip/unzip commands (PR #20832)

curbe454 left a comment (vim/vim#20832)

> The thing I do not like about the new variables is, that you are changing the default types to a list. That will bite each user who has been customizing those variables, so I left that out.

I'm glad to know your attitude to destructive changes. But my original purpose is to introduce customizable zip/unzip commands. I found a hard encoding issue, then found this API is not reasonable.
<https://github.com/vim/vim/blob/975e191dc817d8d00abca7197c4529a417c2f805/runtime/autoload/zip.vim#L252>

If anyone configure to `let g:zip_cmd = '7z'` the `gnu_cmd` would be `keepj sil r! 7z -Z1 -- FPATH`, which always fails. This means the original API exposure is unavailable, or useless. So I introduced the destructive changes.

If destructive changes are not expected, we can cosider another way to implement the functionality. For example, expose more variables.
<https://github.com/vim/vim/blob/1068ea2711d5c0fbb7630835ad9b60a3bf08f83c/runtime/autoload/zip.vim#L59-L81>

-- 
Reply to this email directly or view it on GitHub:
https://github.com/vim/vim/pull/20832#issuecomment-5144613778
You are receiving this because you are subscribed to this thread.

Message ID: <vim/vim/pull/20832/[email protected]>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/20832/c5144613778%40github.com.