Commit: patch 9.2.0889: VMS: spurious "INVALID DECC FEATURE VALUE" message at every startup
Christian Brabandt <[email protected]> Sat, 1 Aug 2026 15:00:05 +0200
| Newsgroups | gmane.editors.vim.devel |
|---|---|
| Message-ID | <[email protected]> |
patch 9.2.0889: VMS: spurious "INVALID DECC FEATURE VALUE" message at every startup Commit: https://github.com/vim/vim/commit/52593298a256f50918b64ee8b5a7fc154dc3422a Author: Scott Klein <[email protected]> Date: Sat Aug 1 10:44:01 2026 +0000 patch 9.2.0889: VMS: spurious "INVALID DECC FEATURE VALUE" message at every startup Problem: On OpenVMS, Vim prints "INVALID DECC FEATURE VALUE" once per DECC feature at every startup whenever that feature is already set to the value Vim wants -- e.g. when DECC$ARGV_PARSE_STYLE, DECC$EFS_CASE_PRESERVE or DECC$EFS_CHARSET are defined as logical names. Conversely, a genuinely out-of-range value is silently ignored, so the diagnostic fires exactly when it should not and never when it should (after v9.1.1591) Solution: Add braces so that the "else" binds to the range check rather than to the inner "if", matching the existing indentation and the evident intent (Scott Klein). related: #17810 closes: #20904 Supported by AI. Signed-off-by: Scott Klein <[email protected]> Signed-off-by: Christian Brabandt <[email protected]> diff --git a/src/os_vms.c b/src/os_vms.c index 17fa06774..3c8229939 100644 --- a/src/os_vms.c +++ b/src/os_vms.c @@ -1005,9 +1005,11 @@ vms_init(void) feat_value_max = decc$feature_get_value(feat_index, 3); if ((decc_feat_array[i].value >= feat_value_min) && (decc_feat_array[i].value <= feat_value_max)) + { // Valid value. Set it if necessary if (feat_value != decc_feat_array[i].value) sts = decc$feature_set_value(feat_index, 1, decc_feat_array[i].value); + } else // Invalid DECC feature value printf("INVALID DECC FEATURE VALUE, %d: %d <= %s <= %d. ", diff --git a/src/version.c b/src/version.c index 0fdd61f59..dcec47b10 100644 --- a/src/version.c +++ b/src/version.c @@ -758,6 +758,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 889, /**/ 888, /**/ -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/vim_dev/E1wq9Jt-007UzR-43%40256bit.org.